Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743972851 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; colu

Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
tirkarthi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743970885 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; col

Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743965474 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; colu

Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743964581 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; colu

Re: [PR] Implement pagination for the new home page. [airflow]

2024-08-30 Thread via GitHub
bbovenzi commented on PR #41905: URL: https://github.com/apache/airflow/pull/41905#issuecomment-2322311634 Looking like a good start! 1. I haven't decided yet if we want to transform the API responses to camelCased. It is definitely more appriopriate to javascript. It may depend on h

Re: [PR] Implement pagination for the new home page. [airflow]

2024-08-30 Thread via GitHub
tirkarthi commented on PR #41905: URL: https://github.com/apache/airflow/pull/41905#issuecomment-2322146966 cc: @bbovenzi @pierrejeambrun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] Implement pagination for the new home page. [airflow]

2024-08-30 Thread via GitHub
tirkarthi opened a new pull request, #41905: URL: https://github.com/apache/airflow/pull/41905 Thanks @bbovenzi for the new UI page and contribution docs. Looks really nice with built in dark mode from ground up. New build system using Vite and HMR is really nice. I don't need to reload for