Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

phanikumv merged PR #36916: URL: https://github.com/apache/airflow/pull/36916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

pankajastro commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1466006778 ## airflow/hooks/utils.py: ## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

pankajastro commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1465998842 ## airflow/triggers/external_task.py: ## @@ -36,6 +38,103 @@ from airflow.utils.state import DagRunState +class WorkflowTrigger(BaseTrigger): +""" +

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

Lee-W commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1465773514 ## airflow/triggers/external_task.py: ## @@ -36,6 +38,103 @@ from airflow.utils.state import DagRunState +class WorkflowTrigger(BaseTrigger): +""" +A t

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

pankajastro commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1463237047 ## airflow/sensors/external_task.py: ## @@ -351,29 +348,30 @@ def execute(self, context: Context) -> None: super().execute(context) else:

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

pankajastro commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1462989027 ## airflow/hooks/utils.py: ## @@ -0,0 +1,125 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Hmm, that makes sense, I'll move

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

eladkal commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1462987666 ## airflow/hooks/utils.py: ## @@ -0,0 +1,125 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: I don't think this is the right plac

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

pankajastro commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1462985345 ## airflow/hooks/utils.py: ## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

phanikumv commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1461700160 ## airflow/hooks/utils.py: ## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

Lee-W commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1461687786 ## airflow/triggers/external_task.py: ## @@ -36,6 +38,106 @@ from airflow.utils.state import DagRunState +class WorkflowTrigger(BaseTrigger): +""" +A t

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

phanikumv commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1461480969 ## airflow/hooks/utils.py: ## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

phanikumv commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1461480969 ## airflow/hooks/utils.py: ## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

Taragolis commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1459696206 ## airflow/hooks/utils.py: ## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

[PR] Improve ExternalTaskSensor Async Implementation [airflow]

pankajastro opened a new pull request, #36916: URL: https://github.com/apache/airflow/pull/36916 This pull request addresses several differences between the synchronous and asynchronous implementations of ExternalTaskSensor. The changes include: **Soft Failure Handling:** - Added s