Re: [PR] Improve breeze command image generation and consistency check [airflow]

2023-10-25 Thread via GitHub
potiuk merged PR #35169: URL: https://github.com/apache/airflow/pull/35169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Improve breeze command image generation and consistency check [airflow]

2023-10-25 Thread via GitHub
potiuk commented on PR #35169: URL: https://github.com/apache/airflow/pull/35169#issuecomment-1778643802 Should be easier to keep those images regenerated now for anyone who: * has breeze installed * has pre-commit installed * changes commands in Breeze Instead of finding

Re: [PR] Improve breeze command image generation and consistency check [airflow]

2023-10-25 Thread via GitHub
potiuk commented on code in PR #35169: URL: https://github.com/apache/airflow/pull/35169#discussion_r1371250007 ## .pre-commit-config.yaml: ## @@ -900,7 +900,7 @@ repos: files: newsfragments/.*\.rst entry: ./scripts/ci/pre_commit/pre_commit_newsfragments.py

[PR] Improve breeze command image generation and consistency check [airflow]

2023-10-25 Thread via GitHub
potiuk opened a new pull request, #35169: URL: https://github.com/apache/airflow/pull/35169 There is no more need to regenerate the images manually via `breeze setup regenerate-command-images`. Also check for consistency of command configuration vs command parameters in Breeze is now done i