Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk merged PR #36333: URL: https://github.com/apache/airflow/pull/36333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36333: URL: https://github.com/apache/airflow/pull/36333#issuecomment-1864867072 > Feel free to merge without my approval (I am now away until next year) Have good holidays :) -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432996303 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432996475 ## docs/apache-airflow-providers-fab/img/diagram_fab_auth_manager_airflow_architecture.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432996058 ## CONTRIBUTING.rst: ## @@ -981,6 +981,58 @@ Documentation for ``apache-airflow`` package and other packages that are closely providers packages are in ``/docs/`` di

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
vincbeck commented on PR #36333: URL: https://github.com/apache/airflow/pull/36333#issuecomment-1864823858 Feel free to merge without my approval (I am now away until next year) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432950398 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432946851 ## docs/apache-airflow-providers-fab/img/diagram_fab_auth_manager_airflow_architecture.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
vincbeck commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432938003 ## docs/apache-airflow-providers-fab/img/diagram_fab_auth_manager_airflow_architecture.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432872570 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432870706 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
josh-fell commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432833345 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFL

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36333: URL: https://github.com/apache/airflow/pull/36333#issuecomment-1864555117 This one should set us on a path where we should be able to convert pretty much all our architecture-like-diagrams to diagrams as a code approach easily. It also allows to iterate

[PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk opened a new pull request, #36333: URL: https://github.com/apache/airflow/pull/36333 Since we are getting more diagrams generated in Airflow using the "diagram as a code" approach, this PR improves the pre-commit to be more suitable to support generation of more of the images coming