uranusjr commented on PR #38664:
URL: https://github.com/apache/airflow/pull/38664#issuecomment-2030955073
Do we even need to do this outside of `get_sorted_triggers` in the first
place? I wonder why we can’t just pass `health_check_threshold` into the
function and do the subquery there ins
hussein-awala commented on PR #38664:
URL: https://github.com/apache/airflow/pull/38664#issuecomment-2031352218
Yes, we can do that, but I think keeping it like this will keep the unit
tests simple, as we can pass the IDs in a list instead of setting up the
trigger table.
--
This is an a
uranusjr commented on PR #38664:
URL: https://github.com/apache/airflow/pull/38664#issuecomment-2031477432
Maybe let’s add some annotation or docstring on `get_sorted_triggers` so
future people know what to expect? At least they need to know to expect a
subquery, not always a Python list or
hussein-awala merged PR #38664:
URL: https://github.com/apache/airflow/pull/38664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
