Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-16 Thread via GitHub
dstandish commented on PR #33242: URL: https://github.com/apache/airflow/pull/33242#issuecomment-1894074083 This is a good optimization. We ran into this exact issue and came up with the same optimization independently. But we were thinking to just add an index since there are a couple ot

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-17 Thread via GitHub
dstandish commented on code in PR #33242: URL: https://github.com/apache/airflow/pull/33242#discussion_r1456148944 ## airflow/models/dag.py: ## @@ -3068,21 +3068,45 @@ def bulk_write_to_db( # Skip these queries entirely if no DAGs can be scheduled to save time.

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-17 Thread via GitHub
joshowen commented on code in PR #33242: URL: https://github.com/apache/airflow/pull/33242#discussion_r1456302037 ## airflow/models/dag.py: ## @@ -3068,21 +3068,45 @@ def bulk_write_to_db( # Skip these queries entirely if no DAGs can be scheduled to save time.

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-17 Thread via GitHub
joshowen commented on code in PR #33242: URL: https://github.com/apache/airflow/pull/33242#discussion_r1456302037 ## airflow/models/dag.py: ## @@ -3068,21 +3068,45 @@ def bulk_write_to_db( # Skip these queries entirely if no DAGs can be scheduled to save time.

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-17 Thread via GitHub
joshowen commented on code in PR #33242: URL: https://github.com/apache/airflow/pull/33242#discussion_r1456302037 ## airflow/models/dag.py: ## @@ -3068,21 +3068,45 @@ def bulk_write_to_db( # Skip these queries entirely if no DAGs can be scheduled to save time.

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-17 Thread via GitHub
dstandish commented on PR #33242: URL: https://github.com/apache/airflow/pull/33242#issuecomment-1896456594 hi @joshowen i moved the query builder to a function and added some testing for the query structure. please take a look. i changed the structure of the query slightly so that we don

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-18 Thread via GitHub
joshowen commented on PR #33242: URL: https://github.com/apache/airflow/pull/33242#issuecomment-1898635315 > hi @joshowen i moved the query builder to a function and added some testing for the query structure. please take a look. i changed the structure of the query slightly so that we don'

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2024-01-22 Thread via GitHub
dstandish merged PR #33242: URL: https://github.com/apache/airflow/pull/33242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Index optimized fast path to avoid slower groupby queryplan [airflow]

2023-10-27 Thread via GitHub
joshowen commented on PR #33242: URL: https://github.com/apache/airflow/pull/33242#issuecomment-1782978113 @uranusjr @amoghrajesh @eladkal Thoughts on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab