[PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-15 Thread via GitHub
tshirtman opened a new pull request, #35663: URL: https://github.com/apache/airflow/pull/35663 As the engine was changed in #32303, and the feature set of this engine is a bit specific, it seems useful to be explicit about it. Added a short explanation about it in the dags documenatit

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-15 Thread via GitHub
boring-cyborg[bot] commented on PR #35663: URL: https://github.com/apache/airflow/pull/35663#issuecomment-1812596718 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-15 Thread via GitHub
tshirtman commented on code in PR #35663: URL: https://github.com/apache/airflow/pull/35663#discussion_r1394254843 ## docs/apache-airflow/core-concepts/dags.rst: ## @@ -802,6 +802,10 @@ match any of the patterns would be ignored (under the hood, ``Pattern.search()`` to match t

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-15 Thread via GitHub
tshirtman commented on code in PR #35663: URL: https://github.com/apache/airflow/pull/35663#discussion_r1394254843 ## docs/apache-airflow/core-concepts/dags.rst: ## @@ -802,6 +802,10 @@ match any of the patterns would be ignored (under the hood, ``Pattern.search()`` to match t

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-15 Thread via GitHub
tshirtman commented on code in PR #35663: URL: https://github.com/apache/airflow/pull/35663#discussion_r1394507496 ## docs/apache-airflow/core-concepts/dags.rst: ## @@ -802,6 +802,10 @@ match any of the patterns would be ignored (under the hood, ``Pattern.search()`` to match t

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-15 Thread via GitHub
potiuk commented on PR #35663: URL: https://github.com/apache/airflow/pull/35663#issuecomment-1813058348 You need to use double backticks in .rst :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-15 Thread via GitHub
uranusjr commented on code in PR #35663: URL: https://github.com/apache/airflow/pull/35663#discussion_r1395231465 ## docs/apache-airflow/core-concepts/dags.rst: ## @@ -802,6 +802,10 @@ match any of the patterns would be ignored (under the hood, ``Pattern.search()`` to match th

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-20 Thread via GitHub
potiuk merged PR #35663: URL: https://github.com/apache/airflow/pull/35663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Indicate usage of the re2 regex engine in the .airflowignore documentation. [airflow]

2023-11-20 Thread via GitHub
boring-cyborg[bot] commented on PR #35663: URL: https://github.com/apache/airflow/pull/35663#issuecomment-1818587201 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.