arjunanan6 commented on PR #34766:
URL: https://github.com/apache/airflow/pull/34766#issuecomment-1751723857
@Taragolis Yikes, what a terrible oversight. I saw the static checks but did
not check it properly enough. Thank you!
--
This is an automated message from the Apache Git Service.
Taragolis commented on PR #34766:
URL: https://github.com/apache/airflow/pull/34766#issuecomment-1751704434
Problem with incorrect path to the PsrpHook, this could be found in case of
running [Static Code
Checks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst)
Taragolis commented on code in PR #34766:
URL: https://github.com/apache/airflow/pull/34766#discussion_r1349516480
##
airflow/providers/microsoft/psrp/provider.yaml:
##
@@ -57,3 +57,7 @@ hooks:
- integration-name: Windows PowerShell Remoting Protocol
python-modules:
arjunanan6 commented on PR #34766:
URL: https://github.com/apache/airflow/pull/34766#issuecomment-1751686587
@hussein-awala or @Taragolis do you see what I am doing wrong here? I added
the connection-type in provider.yaml which appears to be where the provider
info and conns are looked up
arjunanan6 commented on PR #34766:
URL: https://github.com/apache/airflow/pull/34766#issuecomment-1748068205
@hussein-awala I didn't even know you could do a draft, so thanks for
pointing that out. My final version will have a better title, details, etc.
@Taragolis It is kind-of
Taragolis commented on PR #34766:
URL: https://github.com/apache/airflow/pull/34766#issuecomment-1747584331
If this changes are correct, than I guess it more related to
- https://github.com/apache/airflow/issues/28790
--
This is an automated message from the Apache Git Service.
To
Taragolis commented on PR #34766:
URL: https://github.com/apache/airflow/pull/34766#issuecomment-1747581457
> related: https://github.com/apache/airflow/issues/19739
Are you sure that this correct issue? Issue related to
arjunanan6 opened a new pull request, #34766:
URL: https://github.com/apache/airflow/pull/34766
related: #19739
---
**^ Add meaningful description above**
Read the **[Pull Request
arjunanan6 closed pull request #34764: Initial commit
URL: https://github.com/apache/airflow/pull/34764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arjunanan6 opened a new pull request, #34764:
URL: https://github.com/apache/airflow/pull/34764
related: #19739
---
**^ Add meaningful description above**
Read the **[Pull Request
10 matches
Mail list logo