Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-19 Thread via GitHub
gopidesupavan commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1684951239 ## airflow/providers/amazon/aws/sensors/kinesis_analytics.py: ## @@ -0,0 +1,242 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-19 Thread via GitHub
eladkal commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1684691796 ## airflow/providers/amazon/aws/sensors/kinesis_analytics.py: ## @@ -0,0 +1,242 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
gopidesupavan commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1683356622 ## airflow/providers/amazon/aws/sensors/kinesis_analytics.py: ## @@ -0,0 +1,242 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
gopidesupavan commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1683356622 ## airflow/providers/amazon/aws/sensors/kinesis_analytics.py: ## @@ -0,0 +1,242 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
eladkal commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1683344399 ## airflow/providers/amazon/aws/sensors/kinesis_analytics.py: ## @@ -0,0 +1,242 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
vincbeck merged PR #40765: URL: https://github.com/apache/airflow/pull/40765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
vincbeck commented on PR #40765: URL: https://github.com/apache/airflow/pull/40765#issuecomment-2237210422 Awesome job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
gopidesupavan commented on PR #40765: URL: https://github.com/apache/airflow/pull/40765#issuecomment-2237163674 > Some nits and questions but overall I am very impressed! Very good job! There is a lot of code but everything looks good to me :) HI @vincbeck Thank you, Really appreciate

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
gopidesupavan commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1683258907 ## tests/system/providers/amazon/aws/example_kinesis_analytics.py: ## @@ -0,0 +1,271 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
gopidesupavan commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1683258248 ## airflow/providers/amazon/aws/waiters/kinesisanalyticsv2.json: ## @@ -0,0 +1,151 @@ +{ +"version": 2, +"waiters": { +"application_start_comple

Re: [PR] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-18 Thread via GitHub
vincbeck commented on code in PR #40765: URL: https://github.com/apache/airflow/pull/40765#discussion_r1683033986 ## airflow/providers/amazon/aws/waiters/kinesisanalyticsv2.json: ## @@ -0,0 +1,151 @@ +{ +"version": 2, +"waiters": { +"application_start_complete":