Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2024-03-06 Thread via GitHub
github-actions[bot] closed pull request #36228: KPO write_logs does not need to use complicated pod logs reader URL: https://github.com/apache/airflow/pull/36228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2024-02-29 Thread via GitHub
github-actions[bot] commented on PR #36228: URL: https://github.com/apache/airflow/pull/36228#issuecomment-1972189993 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2024-01-15 Thread via GitHub
amoghrajesh commented on code in PR #36228: URL: https://github.com/apache/airflow/pull/36228#discussion_r1452273737 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -703,22 +703,21 @@ def execute_complete(self, context: Context, event: dict, **kwargs):

Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2024-01-15 Thread via GitHub
eladkal commented on code in PR #36228: URL: https://github.com/apache/airflow/pull/36228#discussion_r1452044862 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -703,22 +703,21 @@ def execute_complete(self, context: Context, event: dict, **kwargs):

Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2024-01-13 Thread via GitHub
dstandish commented on code in PR #36228: URL: https://github.com/apache/airflow/pull/36228#discussion_r1451635437 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -703,22 +703,21 @@ def execute_complete(self, context: Context, event: dict, **kwargs):

Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2024-01-10 Thread via GitHub
eladkal commented on code in PR #36228: URL: https://github.com/apache/airflow/pull/36228#discussion_r1448031027 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -703,22 +703,21 @@ def execute_complete(self, context: Context, event: dict, **kwargs):

[PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2023-12-14 Thread via GitHub
dstandish opened a new pull request, #36228: URL: https://github.com/apache/airflow/pull/36228 Method `write_logs` was using pod manager method `read_pod_logs` which has some rather complicated logic that it doesn't need, because it does not "follow" the logs and because by the time we come