Re: [PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-18 Thread via GitHub
potiuk merged PR #40847: URL: https://github.com/apache/airflow/pull/40847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-18 Thread via GitHub
vincbeck commented on code in PR #40847: URL: https://github.com/apache/airflow/pull/40847#discussion_r1683008890 ## airflow/models/renderedtifields.py: ## @@ -153,6 +154,23 @@ def _redact(self): for field, rendered in self.rendered_fields.items(): self.ren

Re: [PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-18 Thread via GitHub
potiuk commented on code in PR #40847: URL: https://github.com/apache/airflow/pull/40847#discussion_r1682454635 ## airflow/models/renderedtifields.py: ## @@ -153,6 +154,23 @@ def _redact(self): for field, rendered in self.rendered_fields.items(): self.rende

Re: [PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-18 Thread via GitHub
potiuk commented on code in PR #40847: URL: https://github.com/apache/airflow/pull/40847#discussion_r1682454635 ## airflow/models/renderedtifields.py: ## @@ -153,6 +154,23 @@ def _redact(self): for field, rendered in self.rendered_fields.items(): self.rende

Re: [PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-18 Thread via GitHub
uranusjr commented on code in PR #40847: URL: https://github.com/apache/airflow/pull/40847#discussion_r1682408210 ## airflow/models/renderedtifields.py: ## @@ -153,6 +154,23 @@ def _redact(self): for field, rendered in self.rendered_fields.items(): self.ren

Re: [PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-17 Thread via GitHub
jscheffl commented on code in PR #40847: URL: https://github.com/apache/airflow/pull/40847#discussion_r1682107441 ## airflow/models/renderedtifields.py: ## @@ -153,6 +154,23 @@ def _redact(self): for field, rendered in self.rendered_fields.items(): self.ren

Re: [PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-17 Thread via GitHub
dstandish commented on code in PR #40847: URL: https://github.com/apache/airflow/pull/40847#discussion_r1681831912 ## airflow/models/renderedtifields.py: ## @@ -153,6 +154,23 @@ def _redact(self): for field, rendered in self.rendered_fields.items(): self.re

[PR] Make BashOperator compatible with Internal API AIP-44 [airflow]

2024-07-17 Thread via GitHub
jscheffl opened a new pull request, #40847: URL: https://github.com/apache/airflow/pull/40847 This is another PR as improvement for internal API in relation to implementation of AIP-69 in PoC PR #40224 - I relaized that BashOperator also has a DB access to update template fields. Thi