Taragolis opened a new pull request, #34744:
URL: https://github.com/apache/airflow/pull/34744
In pendulum 3 (beta) there is no access to `pendulum.tz.timezone` anymore
otherwise we should call `pendulum.timezone` for convert string/integer to
pendulum timezones
```py
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1401708147
##
airflow/utils/timezone.py:
##
@@ -18,14 +18,20 @@
from __future__ import annotations
import datetime as dt
+from functools import lru_cache
from typing impo
Taragolis commented on PR #34744:
URL: https://github.com/apache/airflow/pull/34744#issuecomment-1822581857
@bolkedebruin Would you have a look again? Do you have any concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
potiuk commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1401952963
##
airflow/utils/timezone.py:
##
@@ -273,3 +279,24 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+@lru_cache(m
bolkedebruin commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1401990096
##
airflow/utils/timezone.py:
##
@@ -18,14 +18,20 @@
from __future__ import annotations
import datetime as dt
+from functools import lru_cache
from typing i
bolkedebruin commented on PR #34744:
URL: https://github.com/apache/airflow/pull/34744#issuecomment-1822729643
LGTM with one small question see above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1402047756
##
airflow/utils/timezone.py:
##
@@ -18,14 +18,20 @@
from __future__ import annotations
import datetime as dt
+from functools import lru_cache
from typing impo
bolkedebruin commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1402673852
##
airflow/utils/timezone.py:
##
@@ -18,14 +18,20 @@
from __future__ import annotations
import datetime as dt
+from functools import lru_cache
from typing i
Taragolis commented on PR #34744:
URL: https://github.com/apache/airflow/pull/34744#issuecomment-1823532506
I've cherry picked changes into the #35798 and it fail in multiple new
places, so I would suggest to close this one, and And continue working in that
PR so we would sure that changes
Taragolis commented on PR #34744:
URL: https://github.com/apache/airflow/pull/34744#issuecomment-1824170057
closed in favor of #35798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Taragolis closed pull request #34744: Make core compatible with `pendulum` 3
URL: https://github.com/apache/airflow/pull/34744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1369303186
##
airflow/utils/timezone.py:
##
@@ -18,14 +18,20 @@
from __future__ import annotations
import datetime as dt
+from functools import lru_cache
from typing impo
Felix-neko commented on PR #34744:
URL: https://github.com/apache/airflow/pull/34744#issuecomment-1797022391
Thank you for your PR, bro!
I've checked this version with
https://github.com/apache/airflow/issues/35483 DAG and the the problem with
`NameError: name 'timedelta' is not defined`
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345282919
##
airflow/utils/timezone.py:
##
@@ -273,3 +274,19 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+def parse_
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345294095
##
tests/models/test_dag.py:
##
@@ -94,10 +95,17 @@
from tests.test_utils.timetables import cron_timetable, delta_timetable
TEST_DATE = datetime_tz(2015, 1, 2, 0
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345295349
##
airflow/utils/timezone.py:
##
@@ -273,3 +274,19 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+def parse_
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345428641
##
airflow/utils/timezone.py:
##
@@ -273,3 +274,19 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+def parse
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345435914
##
airflow/utils/timezone.py:
##
@@ -273,3 +274,19 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+def parse_
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345453063
##
tests/models/test_dag.py:
##
@@ -94,10 +95,17 @@
from tests.test_utils.timetables import cron_timetable, delta_timetable
TEST_DATE = datetime_tz(2015, 1, 2,
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345455184
##
airflow/utils/timezone.py:
##
@@ -273,3 +274,19 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+def parse
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345456106
##
tests/models/test_dag.py:
##
@@ -94,10 +95,17 @@
from tests.test_utils.timetables import cron_timetable, delta_timetable
TEST_DATE = datetime_tz(2015, 1, 2, 0
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345456106
##
tests/models/test_dag.py:
##
@@ -94,10 +95,17 @@
from tests.test_utils.timetables import cron_timetable, delta_timetable
TEST_DATE = datetime_tz(2015, 1, 2, 0
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345457352
##
airflow/utils/timezone.py:
##
@@ -273,3 +274,19 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+def parse
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1345460291
##
airflow/utils/timezone.py:
##
@@ -273,3 +274,19 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+def parse_
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1346946226
##
airflow/serialization/serialized_objects.py:
##
@@ -162,9 +163,9 @@ def encode_timezone(var: Timezone) -> str | int:
)
-def decode_timezone(var: str | in
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1346948745
##
airflow/utils/timezone.py:
##
@@ -273,3 +279,24 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+@lru_cache
bolkedebruin commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1347009859
##
airflow/utils/timezone.py:
##
@@ -18,14 +18,20 @@
from __future__ import annotations
import datetime as dt
+from functools import lru_cache
from typing i
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1347070794
##
airflow/serialization/serialized_objects.py:
##
@@ -162,9 +163,9 @@ def encode_timezone(var: Timezone) -> str | int:
)
-def decode_timezone(var: str | i
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1347111539
##
airflow/utils/timezone.py:
##
@@ -18,14 +18,20 @@
from __future__ import annotations
import datetime as dt
+from functools import lru_cache
from typing impo
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1347133750
##
tests/models/test_dag.py:
##
@@ -674,8 +674,8 @@ def test_following_previous_schedule(self):
"""
Make sure DST transitions are properly observe
Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1347171880
##
airflow/utils/timezone.py:
##
@@ -273,3 +279,24 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+@lru_cach
uranusjr commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1347193374
##
airflow/serialization/serialized_objects.py:
##
@@ -162,9 +163,9 @@ def encode_timezone(var: Timezone) -> str | int:
)
-def decode_timezone(var: str | in
notatallshaw-gts commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1349248206
##
tests/models/test_dag.py:
##
@@ -94,10 +95,17 @@
from tests.test_utils.timetables import cron_timetable, delta_timetable
TEST_DATE = datetime_tz(2015,
33 matches
Mail list logo
