potiuk merged PR #36829:
URL: https://github.com/apache/airflow/pull/36829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
amoghrajesh commented on code in PR #36829:
URL: https://github.com/apache/airflow/pull/36829#discussion_r1464286997
##
airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts:
##
@@ -97,7 +99,30 @@ export const parseLogs = (
line.includes(fileSourceFilter)
amoghrajesh commented on code in PR #36829:
URL: https://github.com/apache/airflow/pull/36829#discussion_r1464286997
##
airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts:
##
@@ -97,7 +99,30 @@ export const parseLogs = (
line.includes(fileSourceFilter)
amoghrajesh commented on code in PR #36829:
URL: https://github.com/apache/airflow/pull/36829#discussion_r1464284504
##
airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts:
##
@@ -21,6 +21,8 @@
import { defaultFormatWithTZ } from "src/datetime_utils";
+const saniti
bbovenzi commented on code in PR #36829:
URL: https://github.com/apache/airflow/pull/36829#discussion_r1463605227
##
airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts:
##
@@ -97,7 +99,30 @@ export const parseLogs = (
line.includes(fileSourceFilter)
)
bbovenzi commented on code in PR #36829:
URL: https://github.com/apache/airflow/pull/36829#discussion_r1463599836
##
airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts:
##
@@ -21,6 +21,8 @@
import { defaultFormatWithTZ } from "src/datetime_utils";
+const sanitizeH
amoghrajesh commented on PR #36829:
URL: https://github.com/apache/airflow/pull/36829#issuecomment-1905273903
@bbovenzi pushed the changes using the sanitize-html library, can you take a
look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
amoghrajesh commented on PR #36829:
URL: https://github.com/apache/airflow/pull/36829#issuecomment-1905262526
@bbovenzi attempted it and for the same log messages as the description,
these are the results:
bbovenzi commented on code in PR #36829:
URL: https://github.com/apache/airflow/pull/36829#discussion_r1462169646
##
airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts:
##
@@ -97,6 +101,17 @@ export const parseLogs = (
line.includes(fileSourceFilter)
)
amoghrajesh commented on PR #36829:
URL: https://github.com/apache/airflow/pull/36829#issuecomment-1894915438
@jedcunningham @bbovenzi tried fixing it properly this time, let me know
what you think.
@jedcunningham: I used the cases that you had used to test, many thanks :D
--
This
amoghrajesh opened a new pull request, #36829:
URL: https://github.com/apache/airflow/pull/36829
We had to revert the change https://github.com/apache/airflow/pull/36826 due
to the potential risk of HTML injection. To fix that properly, I have added a
fix which does the foll
13 matches
Mail list logo
