ferruzzi merged PR #41975:
URL: https://github.com/apache/airflow/pull/41975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
dirrao commented on PR #41975:
URL: https://github.com/apache/airflow/pull/41975#issuecomment-2355303374
@eladkal
I'm waiting for the final review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dirrao commented on PR #41975:
URL: https://github.com/apache/airflow/pull/41975#issuecomment-2345227972
> Needs to resolve conflict now.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on PR #41975:
URL: https://github.com/apache/airflow/pull/41975#issuecomment-2344573467
Needs to resolve conflict now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dirrao commented on code in PR #41975:
URL: https://github.com/apache/airflow/pull/41975#discussion_r1744879895
##
airflow/metrics/validators.py:
##
@@ -118,7 +107,7 @@ def get_validator() -> ListValidator:
else:
list_type = DEFAULT_VALIDATOR_TYPE
-return val
ferruzzi commented on code in PR #41975:
URL: https://github.com/apache/airflow/pull/41975#discussion_r1744336098
##
airflow/metrics/validators.py:
##
@@ -118,7 +107,7 @@ def get_validator() -> ListValidator:
else:
list_type = DEFAULT_VALIDATOR_TYPE
-return v
ferruzzi commented on code in PR #41975:
URL: https://github.com/apache/airflow/pull/41975#discussion_r1744224602
##
airflow/metrics/validators.py:
##
@@ -118,7 +107,7 @@ def get_validator() -> ListValidator:
else:
list_type = DEFAULT_VALIDATOR_TYPE
-return v
dirrao commented on code in PR #41975:
URL: https://github.com/apache/airflow/pull/41975#discussion_r1743096119
##
airflow/metrics/validators.py:
##
@@ -118,7 +106,7 @@ def get_validator() -> ListValidator:
else:
list_type = DEFAULT_VALIDATOR_TYPE
-return val
dirrao commented on code in PR #41975:
URL: https://github.com/apache/airflow/pull/41975#discussion_r1743095434
##
tests/core/test_stats.py:
##
@@ -345,76 +326,48 @@ def test_regex_matches(self, match_pattern, expect_incr):
statsd_client.assert_not_called()
-cla
ferruzzi commented on code in PR #41975:
URL: https://github.com/apache/airflow/pull/41975#discussion_r1742580638
##
tests/core/test_stats.py:
##
@@ -345,76 +326,48 @@ def test_regex_matches(self, match_pattern, expect_incr):
statsd_client.assert_not_called()
-c
ferruzzi commented on code in PR #41975:
URL: https://github.com/apache/airflow/pull/41975#discussion_r1742570262
##
airflow/metrics/validators.py:
##
@@ -118,7 +106,7 @@ def get_validator() -> ListValidator:
else:
list_type = DEFAULT_VALIDATOR_TYPE
-return v
dirrao opened a new pull request, #41975:
URL: https://github.com/apache/airflow/pull/41975
Metrics basic deprecated validators (AllowListValidator and
BlockListValidator) removed in favor of pattern matching
--
This is an automated message from the Apache Git Service.
To respond to t
12 matches
Mail list logo
