Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk merged PR #36094: URL: https://github.com/apache/airflow/pull/36094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on PR #36094: URL: https://github.com/apache/airflow/pull/36094#issuecomment-1847758044 Finally ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on PR #36094: URL: https://github.com/apache/airflow/pull/36094#issuecomment-1847628929 We will also need to merge this one https://github.com/apache/airflow/pull/36129 - before, so that users will not have to rebuild image in order to use the new `--use-airflow-version`

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on PR #36094: URL: https://github.com/apache/airflow/pull/36094#issuecomment-1847526986 Still a few nits but I am getting really close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on code in PR #36094: URL: https://github.com/apache/airflow/pull/36094#discussion_r1419731071 ## scripts/in_container/install_airflow_and_providers.py: ## @@ -0,0 +1,448 @@ +#!/usr/bin/env python3 + +# Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on code in PR #36094: URL: https://github.com/apache/airflow/pull/36094#discussion_r1419729586 ## scripts/in_container/install_airflow_and_providers.py: ## @@ -0,0 +1,448 @@ +#!/usr/bin/env python3 + +# Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on code in PR #36094: URL: https://github.com/apache/airflow/pull/36094#discussion_r1419728083 ## scripts/in_container/install_airflow_and_providers.py: ## @@ -0,0 +1,448 @@ +#!/usr/bin/env python3 + +# Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on code in PR #36094: URL: https://github.com/apache/airflow/pull/36094#discussion_r1419723479 ## scripts/in_container/install_airflow_and_providers.py: ## @@ -0,0 +1,448 @@ +#!/usr/bin/env python3 + +# Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

vincbeck commented on code in PR #36094: URL: https://github.com/apache/airflow/pull/36094#discussion_r1419695530 ## scripts/in_container/install_airflow_and_providers.py: ## @@ -0,0 +1,448 @@ +#!/usr/bin/env python3 + +# Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on PR #36094: URL: https://github.com/apache/airflow/pull/36094#issuecomment-1846154781 cc: @vincbeck @eladkal @amoghrajesh @ashb - but it's one-but-last step to remove all the remainders of bash scripts we had for the CI. The remaining part (which I did not want to

Re: [PR] Move Breeze installation of Airflow in CI image to Python [airflow]

potiuk commented on PR #36094: URL: https://github.com/apache/airflow/pull/36094#issuecomment-1846150521 I will likely need a few more rounds of fixes, but this is something I got to while iterating on the fix. - 800 lines of bash code replaced by much more approachable Python code