Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-20 Thread via GitHub
vincbeck merged PR #34924: URL: https://github.com/apache/airflow/pull/34924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769139998 > Here is the way I see it :) There is no such api_auth in auth managers. There are API auth provided by Airflow itself (session, default and deny_all) and API auth provided by auth mana

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769137290 > As far as I understand (and I might be wrong), currently the way how to configure backends in order to get the UI working is: airflow.api.auth.backend.basic_auth,airflow.api.auth.bac

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769122593 > Nice! This way, you just need to do something similar if you want your auth manager to provider Kerberos support! Precisely -- This is an automated message from the Apache Git

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769121909 > > Another solution would be to return NotImplemented by default and try/catch this exception. If this exception is thrown, then no Kerberos > > I'd say we could just leave a ba

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769118838 > Another solution would be to return NotImplemented by default and try/catch this exception. If this exception is thrown, then no Kerberos I'd say we could just leave a base

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769107921 > Obviously. I missed the fact that "session_auth" remained where it was. I see that "session" will remain where it was. Clear. And expectation is that if you implement an AuthManger a

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1768984626 > Multiple answers here :) Because there were multiple questions :) . > > I think we should make it explicit in docs that those authentication backends for the API are

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1768733409 Multiple answers here :) > I think we should make it explicit in docs that those authentication backends for the API are available only when FAB auth manager is used. Likely we

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1768567973 I think we should make it explicit in docs that those authentication backends for the API are available only when FAB auth manager is used. Likely we should also rename/depreceate the co

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-17 Thread via GitHub
vincbeck commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1362623199 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-17 Thread via GitHub
potiuk commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1362543661 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-17 Thread via GitHub
potiuk commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1362543661 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-17 Thread via GitHub
vincbeck commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1362206694 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-16 Thread via GitHub
o-nikolas commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1361313195 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-16 Thread via GitHub
o-nikolas commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1361311059 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-16 Thread via GitHub
vincbeck commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1361303612 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-16 Thread via GitHub
vincbeck commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1361304073 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-16 Thread via GitHub
o-nikolas commented on code in PR #34924: URL: https://github.com/apache/airflow/pull/34924#discussion_r1361299228 ## airflow/auth/managers/fab/api/auth/backend/kerberos_auth.py: ## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-13 Thread via GitHub
vincbeck closed pull request #34924: Move Rest API auth related methods to FAB auth manager URL: https://github.com/apache/airflow/pull/34924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-13 Thread via GitHub
vincbeck opened a new pull request, #34924: URL: https://github.com/apache/airflow/pull/34924 Multiple authentications are possible for the Rest API. [See documentation](https://airflow.apache.org/docs/apache-airflow/stable/security/api.html). With AIP-56, all these configurations besides t