potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875882462
:WHOOO!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
vincbeck merged PR #36232:
URL: https://github.com/apache/airflow/pull/36232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
eladkal commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875875227
> Greeennn!!! 🥳
:tada::tada::tada::tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875871824
Greeennn!!! 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875797940
> Once merged AND doc build succedds AND inventories are pushed to S3 (which
only happens in canary main build which runs after merge.
But yeah. Just realized that in this case doc
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875795832
> I thought the issue was because we had in-flights doc changes (referencing
doc not merged yet).
Nope. This is because there are changes in several packages in the same PR
and t
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875792740
> BTW. It's a bit worrying that it fails on self-hosted - eventually this
build **should** succed in main - because that is how inventories will get
pushed to S3, so if it fails on sel
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875792221
So ... I'd try to remove `use public` and re-run. Hoping that it will
succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875791120
Believe it or not - but I think the failure on self-hosted runners was
accidental
```
Error 143 returned
None
Running command:
Running command:
Running command:
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875788310
BTW. It's a bit worrying that it fails on self-hosted - eventually this
build **should** succed in main - because that is how inventories will get
pushed to S3, so if it fails on self-ho
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875772874
H That's Interesting. Bigger parallelism ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vincbeck closed pull request #36232: Move config related to FAB auth manager to
FAB provider
URL: https://github.com/apache/airflow/pull/36232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1875770958
Spellcheck is failing in self hosted runner but succeeding in public runners
... Interesting ... I'll try again with public runners
--
This is an automated message from the Apache Gi
vincbeck closed pull request #36232: Move config related to FAB auth manager to
FAB provider
URL: https://github.com/apache/airflow/pull/36232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874711988
🎉 SUCCESS
except the MSSQL failure that is 🙀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874701257
Strange. I see jobs being picked up now.. Maybe something temporary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874697879
> Ah... I was also wondering WHY it was running so long - and I see you
added `use public runners` - that's why it was running sooo long... any
problems when using self-hosted ones
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874697186
Ah... I was also wondering WHY it was running so long - and I see you added
`use public runners` - that's why it was running sooo long... any problems
when using self-hosted ones?
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874598166
Icnrease the limit of time for the Spellcheck job. This one was already on
the way to succeed but had been cancelled on timeout. The problem in his case
is that we do several passess and
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874582889
ðŸ˜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
vincbeck closed pull request #36232: Move config related to FAB auth manager to
FAB provider
URL: https://github.com/apache/airflow/pull/36232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874498903
🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1874259329
> OK. Rebasing and removing doc build changes **should** fix the error.
I'll try today :)
--
This is an automated message from the Apache Git Service.
To respond to the message
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1865045657
OK. Rebasing and removing doc build changes **should** fix the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1865007665
In case you are still around @vincbeck - "retry when spelling fails because
of build errors" should be fixed in https://github.com/apache/airflow/pull/36336
--
This is an automated me
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1864820024
> check_spelling
I dont see a `build_errors` in `check_spelling` 👀 . I am now away until next
year so I'll continue playing around then unless someone else solves it
--
This
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863699013
actually... I think better and simpler solution will be to add:
```
build_errors.extend(parse_sphinx_warnings(warning_text, self._src_dir))
```
in `check_spelling`.. An
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863646937
OK. I think the problem is that spell-checking does not properly detect
"build" errors. I saw it in the past that when spelling fails with build
errors, there is no "actual" error prin
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863636816
Arggg ... It is failing :|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863623674
> It worked locally :) Let's see!
It does look like it **could** work :D. And we will see it in the job output
as well.
--
This is an automated message from the Apache Git Servi
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863622806
It worked locally :) Let's see!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863611445
And then of course you should revert passing the "spellcheck_only" flag to
use the original flag. We need tht in order to find out what mode the original
build was called with.
--
Thi
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863608620
I guessed correctly:
```
to_retry_packages = [
package_name
for package_name, errors in package_build_errors.items()
if any(any((m in e.messa
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863594863
> Same error. I only disable the flag spellcheck for iteration #2 and #3. It
should work since the issue is on the same package:
`apache-airflow-providers-fab`. Though, interesting enoug
vincbeck commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863572265
Same error. I only disable the flag spellcheck only for iteration #2 and #3.
It should work since the issue is on the same package:
`apache-airflow-providers-fab`. Though, interesting
potiuk commented on PR #36232:
URL: https://github.com/apache/airflow/pull/36232#issuecomment-1863447303
Let's see :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
vincbeck opened a new pull request, #36232:
URL: https://github.com/apache/airflow/pull/36232
Some config is now used only by the new fab provider. Thus, we should move
this config to the provider
See #32210.
---
**^ Add meaningful description abo
37 matches
Mail list logo
