Re: [PR] Move methods used only in FAB from security managers to auth manager [airflow]

2023-11-01 Thread via GitHub
vincbeck merged PR #35203: URL: https://github.com/apache/airflow/pull/35203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Move methods used only in FAB from security managers to auth manager [airflow]

2023-11-01 Thread via GitHub
ephraimbuddy commented on code in PR #35203: URL: https://github.com/apache/airflow/pull/35203#discussion_r1378870349 ## airflow/auth/managers/fab/security_manager/override.py: ## @@ -760,6 +764,171 @@ def can_access_some_dags(self, action: str, dag_id: str | None = None) ->

Re: [PR] Move methods used only in FAB from security managers to auth manager [airflow]

2023-11-01 Thread via GitHub
vincbeck commented on PR #35203: URL: https://github.com/apache/airflow/pull/35203#issuecomment-1789035460 This one should also improve the code coverage of the `auth` module. @ephraimbuddy -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Move methods used only in FAB from security managers to auth manager [airflow]

2023-10-26 Thread via GitHub
vincbeck opened a new pull request, #35203: URL: https://github.com/apache/airflow/pull/35203 Move methods used only in FAB from security managers to auth manager. I also simplified the way the security manager is instantiated. --- **^ Add meaningful