github-actions[bot] closed pull request #38281: New generaic SQL transfer
operator proposal
URL: https://github.com/apache/airflow/pull/38281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
github-actions[bot] commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2097129835
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
potiuk commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2015813508
Probably yes. How to perform that?
> Just the usual "Refactor -> Extract" - both are in common.sql provider, so
adding `common.sql.util` package with `provider_compatibility.py` a
frodo2000 commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2015774537
> How about extracting the common code for version check? Sounds reasonable
to do it now?
Probably yes. How to perform that?
--
This is an automated message from the Apache G
potiuk commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2015543690
How about extracting the common code for version check? Sounds reasonable to
do it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1535923249
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
frodo2000 commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1535918264
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
frodo2000 commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1535903310
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1535889610
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
frodo2000 commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1535879059
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1535872604
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1535871750
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
eladkal commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532530343
##
airflow/providers/common/sql/provider.yaml:
##
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1709555283
# note that those versions are maintained by release
frodo2000 commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532378555
##
airflow/providers/common/sql/CHANGELOG.rst:
##
@@ -25,6 +25,14 @@
Changelog
-
+1.12.0
+..
+
+Features
+
+
+* ``New generic SQL tranfer op
frodo2000 commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532377055
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532366055
##
airflow/providers/common/sql/provider.yaml:
##
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1709555283
# note that those versions are maintained by release m
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532364475
##
airflow/providers/common/sql/provider.yaml:
##
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1709555283
# note that those versions are maintained by release m
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532364475
##
airflow/providers/common/sql/provider.yaml:
##
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1709555283
# note that those versions are maintained by release m
eladkal commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2009922543
> @Taragolis @potiuk @eladkal Operator passed the test. Additionally I had
check the following hooks and DB:
>
> * IBM DB2 (ODBC Hook)
> * Oracle (Oracle Hook)
> * MySQL (my
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532355955
##
airflow/providers/common/sql/CHANGELOG.rst:
##
@@ -28,6 +28,14 @@ Changelog
1.11.1
Review Comment:
New feature. We are adding new feature - so we should increa
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532355955
##
airflow/providers/common/sql/CHANGELOG.rst:
##
@@ -28,6 +28,14 @@ Changelog
1.11.1
Review Comment:
New feature. We are adding new feature - so we should increa
eladkal commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532360493
##
airflow/providers/common/sql/provider.yaml:
##
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1709555283
# note that those versions are maintained by release
eladkal commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532359288
##
airflow/providers/common/sql/CHANGELOG.rst:
##
@@ -25,6 +25,14 @@
Changelog
-
+1.12.0
+..
+
+Features
+
+
+* ``New generic SQL tranfer oper
Taragolis commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1532350528
##
airflow/providers/common/sql/CHANGELOG.rst:
##
@@ -28,6 +28,14 @@ Changelog
1.11.1
Review Comment:
Is it braking/significant changes? We don't have to add i
frodo2000 commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2009475855
@Taragolis @potiuk @eladkal Operator passed the test.
Additionally I had check the following hooks and DB:
- IBM DB2 (ODBC Hook)
- Oracle (Oracle Hook)
- MySQL (mySQL Hook)
frodo2000 commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1531676730
##
airflow/providers/common/sql/CHANGELOG.rst:
##
@@ -28,6 +28,14 @@ Changelog
1.11.1
Review Comment:
Fixed
--
This is an automated message from the Apache
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1531636418
##
airflow/providers/common/sql/CHANGELOG.rst:
##
@@ -28,6 +28,14 @@ Changelog
1.11.1
Review Comment:
1.12.0
--
This is an automated message from the Apache G
potiuk commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2008674800
Explanation of the `mypy` problem:
The MyPy Issue is because for DBApiHook we have a .pyi interface as well
defined (to flag any case where we change the interface. See
`common.sq
frodo2000 commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2008122313
@Taragolis @potiuk @eladkal I had changed code for that provider. Transfer
logic is moved to:
- DBApiHook - generic transfer
- OracleHook - Oracle bulk insert transfer
- S
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1530775208
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
Taragolis commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1530772901
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
eladkal commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1530695191
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
potiuk commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1530628185
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
frodo2000 commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1530490567
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
Taragolis commented on code in PR #38281:
URL: https://github.com/apache/airflow/pull/38281#discussion_r1530474082
##
airflow/providers/common/sql/transfers/sql.py:
##
@@ -0,0 +1,248 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
potiuk commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2006711785
Also - we should make the Generic Transfer from `airflow.operatror`
deprecated as this is a superset of the Generic Transfer (and common.sql is way
better place for such a generic transf
potiuk commented on PR #38281:
URL: https://github.com/apache/airflow/pull/38281#issuecomment-2006703379
That looks good in general, but before we geto more detailed review we need
some unit tests on it (as for any other new code).
--
This is an automated message from the Apache Git Servi
frodo2000 opened a new pull request, #38281:
URL: https://github.com/apache/airflow/pull/38281
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#
38 matches
Mail list logo
