Re: [PR] Open search integrations [airflow]

2023-10-16 Thread via GitHub
cjames23 commented on PR #34693: URL: https://github.com/apache/airflow/pull/34693#issuecomment-1765158146 Closing this PR in favor of actually just adding the auth required in the OpenSearch provider to simplify dependency management and code management. I will open a new PR in the coming

Re: [PR] Open search integrations [airflow]

2023-10-16 Thread via GitHub
cjames23 closed pull request #34693: Open search integrations URL: https://github.com/apache/airflow/pull/34693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Open search integrations [airflow]

2023-10-15 Thread via GitHub
cjames23 commented on code in PR #34693: URL: https://github.com/apache/airflow/pull/34693#discussion_r1359985505 ## airflow/providers/amazon/aws/hooks/opensearch.py: ## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Open search integrations [airflow]

2023-10-15 Thread via GitHub
eladkal commented on code in PR #34693: URL: https://github.com/apache/airflow/pull/34693#discussion_r1359933438 ## airflow/providers/amazon/aws/hooks/opensearch.py: ## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Open search integrations [airflow]

2023-10-03 Thread via GitHub
vincbeck commented on code in PR #34693: URL: https://github.com/apache/airflow/pull/34693#discussion_r1344564045 ## airflow/providers/amazon/aws/operators/opensearch.py: ## @@ -0,0 +1,189 @@ +# Review Comment: Sounds like very good to me  ##

Re: [PR] Open search integrations [airflow]

2023-10-03 Thread via GitHub
cjames23 commented on code in PR #34693: URL: https://github.com/apache/airflow/pull/34693#discussion_r1344556720 ## airflow/providers/amazon/aws/operators/opensearch.py: ## @@ -0,0 +1,189 @@ +# Review Comment: This PR is on hold right now until the other PR is ready. Once

Re: [PR] Open search integrations [airflow]

2023-10-03 Thread via GitHub
vincbeck commented on code in PR #34693: URL: https://github.com/apache/airflow/pull/34693#discussion_r1344502835 ## airflow/providers/amazon/aws/operators/opensearch.py: ## @@ -0,0 +1,189 @@ +# Review Comment: Quite related to this [comment

Re: [PR] Open search integrations [airflow]

2023-10-03 Thread via GitHub
Taragolis commented on code in PR #34693: URL: https://github.com/apache/airflow/pull/34693#discussion_r1344266894 ## airflow/providers/amazon/aws/hooks/opensearch.py: ## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor