Re: [PR] Pass SSL arg to all requests in DruidOperator [airflow]

2024-05-04 Thread via GitHub
eladkal merged PR #39066: URL: https://github.com/apache/airflow/pull/39066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Pass SSL arg to all requests in DruidOperator [airflow]

2024-05-03 Thread via GitHub
danielbe11 commented on PR #39066: URL: https://github.com/apache/airflow/pull/39066#issuecomment-2094045316 @dirrao could you please approve the pr if you're happy with it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Pass SSL arg to all requests in DruidOperator [airflow]

2024-04-25 Thread via GitHub
danielbe11 commented on code in PR #39066: URL: https://github.com/apache/airflow/pull/39066#discussion_r1579313516 ## airflow/providers/apache/druid/hooks/druid.py: ## @@ -144,13 +144,15 @@ def submit_indexing_job( sec = 0 while running: -req_sta

Re: [PR] Pass SSL arg to all requests in DruidOperator [airflow]

2024-04-18 Thread via GitHub
danielbe11 commented on PR #39066: URL: https://github.com/apache/airflow/pull/39066#issuecomment-2063474612 Thanks for the review @dirrao, added the other test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] Pass SSL arg to all requests in DruidOperator [airflow]

2024-04-16 Thread via GitHub
danielbe11 opened a new pull request, #39066: URL: https://github.com/apache/airflow/pull/39066 - We're currently only passing the `verify` kwarg in the first post request (the one assigning `req_index` var). We should be passing the arg to all the requests in the operator. - For contex