Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2024-01-20 Thread via GitHub
eladkal merged PR #33786: URL: https://github.com/apache/airflow/pull/33786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2024-01-20 Thread via GitHub
shahar1 commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1902090286 > d exclusion list of operators to the pre-commit (the ones that are not ready). This should give us green build here thus we can merge this PR and enjoy the protection it brings.

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2024-01-20 Thread via GitHub
eladkal commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1902071627 I think we can also improve the process here as it takes longer to finish the list of operators to handle. @shahar1 you can add exclusion list of operators to the pre-commit (the

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2023-12-29 Thread via GitHub
shahar1 commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1872147699 > > @shahar1 I see that the pre-commit found some invalid usages which is awesome. > > I suggest to handle them in separated PR(s) then once all merged you can rebase this one and it

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2023-12-23 Thread via GitHub
potiuk commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1868308640 > @shahar1 I see that the pre-commit found some invalid usages which is awesome. I suggest to handle them in separated PR(s) then once all merged you can rebase this one and it wi

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2023-12-23 Thread via GitHub
shahar1 commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1868306978 > @shahar1 I see that the pre-commit found some invalid usages which is awesome. > I suggest to handle them in separated PR(s) then once all merged you can rebase this one and it wil

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2023-12-23 Thread via GitHub
eladkal commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1868306737 @shahar1 I see that the pre-commit found some invalid usages which is awesome. I suggest to handle them in separated PR(s) then once all merged you can rebase this one and it will be

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2023-12-16 Thread via GitHub
shahar1 commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1858814207 @potiuk @hussein-awala @Taragolis @eladkal I tried my best to come up with assumptions that make sense and develop a useful pre-commit that will help us regulating the templated fiel

Re: [PR] Prevent templated field logic checks in __init__ of operators automatically [airflow]

2023-10-26 Thread via GitHub
github-actions[bot] commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1782099531 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you