Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

dstandish merged PR #37855: URL: https://github.com/apache/airflow/pull/37855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

dstandish commented on PR #37855: URL: https://github.com/apache/airflow/pull/37855#issuecomment-1992691317 the one test failure is already present in main ( see https://github.com/apache/airflow/actions/runs/8255201886/job/22581344328) So will merge anyway -- This is an automated

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

uranusjr commented on code in PR #37855: URL: https://github.com/apache/airflow/pull/37855#discussion_r1522058143 ## airflow/serialization/serialized_objects.py: ## @@ -528,18 +546,11 @@ def serialize( def _pydantic_model_dump(model_cls: type[BaseModel], var: Any) -

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

dstandish commented on PR #37855: URL: https://github.com/apache/airflow/pull/37855#issuecomment-1992497027 @potiuk i have created a discussion item for this https://github.com/apache/airflow/discussions/38087 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

potiuk commented on PR #37855: URL: https://github.com/apache/airflow/pull/37855#issuecomment-1987142108 > @potiuk initially I was going to write a check that all pydantic models we define can round trip. However, as yet some pydantic models do not have types defined (as in DAT.THE_MODEL).

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

dstandish commented on PR #37855: URL: https://github.com/apache/airflow/pull/37855#issuecomment-1986473426 hrm getting a "no module pydantic" in one of the tests... any idea why? https://github.com/apache/airflow/actions/runs/8206540755/job/22454242808?pr=37855#step:5:1603 -- Thi

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

dstandish commented on PR #37855: URL: https://github.com/apache/airflow/pull/37855#issuecomment-1986111612 @potiuk initially I was going to write a check that all pydantic models we define can round trip. However, as yet some pydantic models do not have types defined (as in DAT.THE_MODEL)

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

uranusjr commented on PR #37855: URL: https://github.com/apache/airflow/pull/37855#issuecomment-1980129600 Instead of adding isinstance checks everywhere, maybe we should just add a Pydantic-specific branch at the top so all Pydantic models automatically roundtrip automatically. -- This

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

potiuk commented on code in PR #37855: URL: https://github.com/apache/airflow/pull/37855#discussion_r1513780030 ## airflow/serialization/serialized_objects.py: ## @@ -528,17 +528,17 @@ def serialize( def _pydantic_model_dump(model_cls: type[BaseModel], var: Any) ->

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

dstandish commented on code in PR #37855: URL: https://github.com/apache/airflow/pull/37855#discussion_r1511844501 ## airflow/serialization/serialized_objects.py: ## @@ -528,17 +528,17 @@ def serialize( def _pydantic_model_dump(model_cls: type[BaseModel], var: Any)

Re: [PR] Properly serialize TaskInstancePydantic and DagRunPydantic [airflow]

dstandish commented on PR #37855: URL: https://github.com/apache/airflow/pull/37855#issuecomment-1977504593 > Does this serialized object data go into the database? Can you add a test case for this change? Well, our serializer can be used in different ways. But typically the use cas