Re: [PR] Refactor DAG tabs navigation [airflow]

2024-04-02 Thread via GitHub
jscheffl commented on PR #38592: URL: https://github.com/apache/airflow/pull/38592#issuecomment-2033089071 @bbovenzi Meaning closing in (1) favor _not_ blocking 2.9 release and make the rework in 2.10 or (2) another PR that you open (soon)? -- This is an automated message from the Apache

Re: [PR] Refactor DAG tabs navigation [airflow]

2024-04-02 Thread via GitHub
bbovenzi commented on PR #38592: URL: https://github.com/apache/airflow/pull/38592#issuecomment-2032435301 Closing in favor of a different approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Refactor DAG tabs navigation [airflow]

2024-04-02 Thread via GitHub
bbovenzi closed pull request #38592: Refactor DAG tabs navigation URL: https://github.com/apache/airflow/pull/38592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Refactor DAG tabs navigation [airflow]

2024-04-02 Thread via GitHub
vatsrahul1001 commented on PR #38592: URL: https://github.com/apache/airflow/pull/38592#issuecomment-2031419584 Love it! I agree with the changes proposed by @jscheffl. I noticed a few issues while checking the logs for the mapped task: 1. The vertical scroll bar in the grid view does

Re: [PR] Refactor DAG tabs navigation [airflow]

2024-03-29 Thread via GitHub
potiuk commented on PR #38592: URL: https://github.com/apache/airflow/pull/38592#issuecomment-2027354786 Agree. Love that. Let's make it a highlight of 2.9.0. And the changes proposed by Jens are good. There is one small caveat of that - multiple rows of tabs are quite confusing. But

Re: [PR] Refactor DAG tabs navigation [airflow]

2024-03-29 Thread via GitHub
jscheffl commented on PR #38592: URL: https://github.com/apache/airflow/pull/38592#issuecomment-2027093889 My Feedback: 1. @ephraimbuddy even if a late arrival, can we get this into 2.9? 2. The DAG/Run/Task Details are the most common and standard informations. I'd propose to put t

Re: [PR] Refactor DAG tabs navigation [airflow]

2024-03-28 Thread via GitHub
jedcunningham commented on PR #38592: URL: https://github.com/apache/airflow/pull/38592#issuecomment-2026057162 I pulled this up and experimented with it for a few minutes. I like it. It's intuitive and easy to use. -- This is an automated message from the Apache Git Service. To respond t

[PR] Refactor DAG tabs navigation [airflow]

2024-03-28 Thread via GitHub
bbovenzi opened a new pull request, #38592: URL: https://github.com/apache/airflow/pull/38592 We got rid of all of the old DAG pages and their buttons. But in the grid view, the tabs displayed depended on the task+run selection. It was then confusing as to where views disappeared to. Instea