vishnucoder1 opened a new pull request, #35356:
URL: https://github.com/apache/airflow/pull/35356
As a part of this PR, existing `start_date` validation is removed to handle
`schedule=None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
vishnucoder1 commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1802392615
@uranusjr Do we need to fail explicitly for non None Schedule and empty
start date? In this case, it will start the job based on schedule I believe.
--
This is an automated messa
hussein-awala commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1387237858
##
tests/models/test_dag.py:
##
@@ -827,6 +827,15 @@ def test_following_schedule_datetime_timezone(self):
when = dag.following_schedule(start)
vishnucoder1 commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1806336580
Also want to mention that previously start date and task date were checked
to throw the start date error which is part of add task. But schedule will not
be empty then as it will b
vishnucoder1 commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1814480828
@uranusjr @eladkal @hussein-awala
Need your inputs here. Do we need to fail explicitly for non None Schedule
and empty start date? Should task date also be considered. But con
uranusjr commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1815846312
If I remember correctly, we currently fail explicitly for that combination,
so it’s better to continue the behaviour. Having a DAG created silently but can
never fire can be confusing
vishnucoder1 commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1816391989
Thanks for the input. Changes are added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
eladkal commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1816635450
Tests are failing:
```
ERROR
tests/providers/amazon/aws/operators/test_athena.py::TestAthenaOperator::test_return_value
- ValueError: DAG is missing the start_date parameter
vishnucoder1 commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1817472004
Fixed the failing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uranusjr commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1401521841
##
airflow/utils/helpers.py:
##
@@ -325,6 +325,24 @@ def is_set(val):
return sum(map(is_set, args)) in (0, 1)
+def at_least_one(*args) -> bool:
+"""
+
uranusjr commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1401521841
##
airflow/utils/helpers.py:
##
@@ -325,6 +325,24 @@ def is_set(val):
return sum(map(is_set, args)) in (0, 1)
+def at_least_one(*args) -> bool:
+"""
+
uranusjr commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1401521841
##
airflow/utils/helpers.py:
##
@@ -325,6 +325,24 @@ def is_set(val):
return sum(map(is_set, args)) in (0, 1)
+def at_least_one(*args) -> bool:
+"""
+
vishnucoder1 commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1402445487
##
airflow/utils/helpers.py:
##
@@ -325,6 +325,24 @@ def is_set(val):
return sum(map(is_set, args)) in (0, 1)
+def at_least_one(*args) -> bool:
+"""
eladkal merged PR #35356:
URL: https://github.com/apache/airflow/pull/35356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
eladkal commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1379131926
##
tests/models/test_dag.py:
##
@@ -827,6 +827,15 @@ def test_following_schedule_datetime_timezone(self):
when = dag.following_schedule(start)
asser
hussein-awala commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1379146142
##
tests/models/test_dag.py:
##
@@ -827,6 +827,15 @@ def test_following_schedule_datetime_timezone(self):
when = dag.following_schedule(start)
eladkal commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1379150779
##
tests/models/test_dag.py:
##
@@ -827,6 +827,15 @@ def test_following_schedule_datetime_timezone(self):
when = dag.following_schedule(start)
asser
vishnucoder1 commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1379203897
##
tests/models/test_dag.py:
##
@@ -827,6 +827,15 @@ def test_following_schedule_datetime_timezone(self):
when = dag.following_schedule(start)
hussein-awala commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1379343241
##
tests/models/test_dag.py:
##
@@ -827,6 +827,15 @@ def test_following_schedule_datetime_timezone(self):
when = dag.following_schedule(start)
eladkal commented on code in PR #35356:
URL: https://github.com/apache/airflow/pull/35356#discussion_r1381803502
##
tests/models/test_dag.py:
##
@@ -827,6 +827,15 @@ def test_following_schedule_datetime_timezone(self):
when = dag.following_schedule(start)
asser
uranusjr commented on PR #35356:
URL: https://github.com/apache/airflow/pull/35356#issuecomment-1794322802
Do we have a test for a non-None schedule raising an exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
21 matches
Mail list logo
