Re: [PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-07-03 Thread via GitHub
potiuk commented on PR #40286: URL: https://github.com/apache/airflow/pull/40286#issuecomment-2205854126 > #34405 , is that not a concern ? > > airflow that stop working cause otel-collector is down is not similar to what happen with statsd It's independent from being "experime

Re: [PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-07-03 Thread via GitHub
raphaelauv commented on PR #40286: URL: https://github.com/apache/airflow/pull/40286#issuecomment-2205748120 @potiuk @ferruzzi https://github.com/apache/airflow/issues/34405 , is that not a concern ? airflow that stop working cause otel-collector is down is not similar to wh

Re: [PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-07-02 Thread via GitHub
utkarsharma2 commented on PR #40286: URL: https://github.com/apache/airflow/pull/40286#issuecomment-220578 > I think the change could be applied manually - this is a very simple change - we've done that in the past. Sure, I'll manually apply them. -- This is an automated messa

Re: [PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-07-02 Thread via GitHub
potiuk commented on PR #40286: URL: https://github.com/apache/airflow/pull/40286#issuecomment-2203207650 Yeah. I think it would be great to include that one. Really the banner was a mistake - it is enough to describe feature as experimental, showing a banner is a bad idea, because if someon

Re: [PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-06-18 Thread via GitHub
ferruzzi commented on code in PR #40286: URL: https://github.com/apache/airflow/pull/40286#discussion_r1644947942 ## airflow/www/templates/airflow/dags.html: ## @@ -119,12 +119,6 @@ Click here for more information. {% endcall %} {% endif %} - {% if otel_metrics_o

Re: [PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-06-18 Thread via GitHub
ferruzzi commented on PR #40286: URL: https://github.com/apache/airflow/pull/40286#issuecomment-2176491601 I'll get the voting thread going and add the news fragment, thanks folks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-06-17 Thread via GitHub
potiuk commented on code in PR #40286: URL: https://github.com/apache/airflow/pull/40286#discussion_r1643859452 ## airflow/www/templates/airflow/dags.html: ## @@ -119,12 +119,6 @@ Click here for more information. {% endcall %} {% endif %} - {% if otel_metrics_on

[PR] Remove "experimental" banner for OTel Metrics [airflow]

2024-06-17 Thread via GitHub
ferruzzi opened a new pull request, #40286: URL: https://github.com/apache/airflow/pull/40286 OpenTelemetry metrics have been live for a while now and there have been no major bugs except the ongoing discussions around timers reporting in seconds or milliseconds ([example](https://github.co