Re: [PR] Remove old graph [airflow]

2024-01-18 Thread via GitHub
wpromatt commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1899760156 This is also true when clicking on dag_run from the list dag_run tables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Remove old graph [airflow]

2024-01-18 Thread via GitHub
wpromatt commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1899727667 @potiuk The only thing I can't figure out with this new view is how to go to the "graph" view from a link to the task logs. The redirection doesn't work when the dag run you're trying

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
TedHaleyPDL commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841722144 I was hoping for feedback on my comments as this is THE place to discuss the changes implemented by this PR with those who made them. Opening an issue might be a waste of everyones

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
potiuk commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841697253 I think I asked you to open a new issue with those suggestions. It makes no sense to add comments to closed and merged PR. Those are interesting comments and adding them as suggestions f

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
TedHaleyPDL commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841696719 Additionally, while straight lines to show dependencies between tasks looks orderly, it is harder to follow when there are multiple parallel and overlapping lines. The edges in the

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
TedHaleyPDL commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841690997 I think the update essentially had the inverse effect of what it was trying to accomplish. By trying to include as much information as possible within the nodes (and subsequent dens

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
TedHaleyPDL commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841679430 ![Screenshot 2023-10-17 at 2 54 56  PM](https://github.com/apache/airflow/assets/93050126/ec677340-5208-49c8-bfe7-e4c456f85a1a) ![Screenshot 2023-12-05 at 1 50 01  PM](https://gith

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
potiuk commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841552949 Ideally with screenshots before, after (latest version) and clearly marking what exactly the problem you want to solve. -- This is an automated message from the Apache Git Service. To

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
potiuk commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841550556 > This new graph conveys much less information than the past graph and is far more difficult to follow in complex dags. Hovering over no longer isolates the upstream and downstream tasks

Re: [PR] Remove old graph [airflow]

2023-12-05 Thread via GitHub
TedHaleyPDL commented on PR #32958: URL: https://github.com/apache/airflow/pull/32958#issuecomment-1841537840 This new graph conveys much less information than the past graph and is far more difficult to follow in complex dags. Hovering over no longer isolates the upstream and downstream ta