Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
boring-cyborg[bot] commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2132343782 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
potiuk merged PR #39833: URL: https://github.com/apache/airflow/pull/39833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2132343239 Non-DB tests fixed already in main. merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-26 Thread via GitHub
potiuk commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2132219330 No - it's real duplication. The pre-commit looks for file name in the comment: "# The content below is automatically copied from scripts/docker/create_prod_venv.sh" and insert the conten

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-25 Thread via GitHub
RNHTTR commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2131307443 I think there's actually a pre-commit hook that builds these blocks ([see here](https://github.com/apache/airflow/blob/main/Dockerfile#L81-L86)). -- This is an automated message from t

Re: [PR] Remove redundant code from Dockerfile [airflow]

2024-05-25 Thread via GitHub
boring-cyborg[bot] commented on PR #39833: URL: https://github.com/apache/airflow/pull/39833#issuecomment-2131274318 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Remove redundant code from Dockerfile [airflow]

2024-05-25 Thread via GitHub
surawut-jirasaktavee opened a new pull request, #39833: URL: https://github.com/apache/airflow/pull/39833 ### Remove Redundant Code in Dockerfile This pull request removes a duplicated block of code in the Dockerfile. The redundant code was found in the section respons