dstandish merged PR #38571:
URL: https://github.com/apache/airflow/pull/38571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
uranusjr commented on PR #38571:
URL: https://github.com/apache/airflow/pull/38571#issuecomment-2031011676
I hope we’ll be able to clean up the try_number bs when we implement AIP-64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
uranusjr commented on code in PR #38571:
URL: https://github.com/apache/airflow/pull/38571#discussion_r1547093071
##
airflow/models/taskinstance.py:
##
@@ -532,8 +531,7 @@ def _refresh_from_db(
task_instance.end_date = ti.end_date
task_instance.duration = ti.du
dstandish commented on PR #38571:
URL: https://github.com/apache/airflow/pull/38571#issuecomment-2028378771
figured out what was going on here. it was a very confusing one. not
obvious. basically, when switching it back to just query the TI, this had the
effect of incrementing try_number
dstandish commented on PR #38571:
URL: https://github.com/apache/airflow/pull/38571#issuecomment-2028255533
oh -- I thought you merged it @jedcunningham -- sorry i was confused 🙃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dstandish commented on PR #38571:
URL: https://github.com/apache/airflow/pull/38571#issuecomment-2027918211
Yeah there was some weird error related to a test of sensor. I don’t think
it’s really an issue probably something with the test but I was still working
through it
--
This is an a
potiuk commented on PR #38571:
URL: https://github.com/apache/airflow/pull/38571#issuecomment-2027829935
Those test failure looked like abrupt failure of the docker engine in the
middle of testing. I re-run just the tests and if it appears again then we have
something interesting here.
--
jedcunningham commented on PR #38571:
URL: https://github.com/apache/airflow/pull/38571#issuecomment-2027702306
> I think there were still some tests failing @jedcunningham
The 1 I looked at didn't seem obviously related, in the 10 seconds I looked
at it. So I figured a fresh run woul
dstandish commented on PR #38571:
URL: https://github.com/apache/airflow/pull/38571#issuecomment-2027699902
I think there were still some tests failing @jedcunningham
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dstandish opened a new pull request, #38571:
URL: https://github.com/apache/airflow/pull/38571
This was originally added in #28900 presumably for compatiblity with
serialization. Maybe things have changed since then, because it's actually the
Row object that does not serialize properly (an
10 matches
Mail list logo
