Re: [PR] Remove state sync during celery task processing [airflow]

2024-09-18 Thread via GitHub
o-nikolas commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2359453012 @ashb Just another ping post Airflow Summit, do you want to weigh in? Or shall we go ahead and merge this? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Remove state sync during celery task processing [airflow]

2024-09-04 Thread via GitHub
Kytha commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2330190525 >here is also a possible pool configuration, so celery backend can use pooling. As you mentioned NullPool is used only when process is not forked. But what does it mean that process i

Re: [PR] Remove state sync during celery task processing [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2323093079 Also another question: https://airflow.apache.org/docs/apache-airflow-providers-celery/stable/configurations-ref.html#result-backend-sqlalchemy-engine-options -> there is also a

Re: [PR] Remove state sync during celery task processing [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2323080871 It's an interesting one. And yeah - nice analysis @Kytha ! Looks like the original code was supposed to handle "quick" tasks - but It did not take into account that - apparently -

Re: [PR] Remove state sync during celery task processing [airflow]

2024-08-30 Thread via GitHub
eladkal commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2322180710 Nice analysis. Though I think we need to check why this code is there to begin with, there may be a reason we are missing. Also, this fix is based on the assumption: > imme

Re: [PR] Remove state sync during celery task processing [airflow]

2024-08-29 Thread via GitHub
boring-cyborg[bot] commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2319577802 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Remove state sync during celery task processing [airflow]

2024-08-29 Thread via GitHub
Kytha opened a new pull request, #41870: URL: https://github.com/apache/airflow/pull/41870 An Airflow scheduler performance test highlighted a very hot piece of code in the celery executor when using a database results backend. This code seemed to be doing redundant work. Be