Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2024-01-10 Thread via GitHub
vincbeck commented on PR #35504: URL: https://github.com/apache/airflow/pull/35504#issuecomment-1885120967 > Hmm I see, looking at the traceback, that the error is raised from `read_pod_logs`, which is already wrapped with tenacity. Perhaps instead of adding "more tenacity" at higher level,

Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2024-01-09 Thread via GitHub
dstandish commented on PR #35504: URL: https://github.com/apache/airflow/pull/35504#issuecomment-1884141124 Hmm I see, looking at the traceback, that the error is raised from `read_pod_logs`, which is already wrapped with tenacity. Perhaps instead of adding "more tenacity" at higher level,

Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2024-01-09 Thread via GitHub
dstandish commented on PR #35504: URL: https://github.com/apache/airflow/pull/35504#issuecomment-1884137309 > Sorry this took so long @dstandish! You can see the traceback that we see in the tests (for which Vincent's retry resolved and are now back). There is also some other diagnostic inf

Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2024-01-08 Thread via GitHub
o-nikolas commented on PR #35504: URL: https://github.com/apache/airflow/pull/35504#issuecomment-1881955174 > Could you share the traceback? Sorry this took so long @dstandish! You can see the traceback that we see in the tests (for which Vincent's retry resolved and are now back). Th

Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2024-01-04 Thread via GitHub
dstandish commented on PR #35504: URL: https://github.com/apache/airflow/pull/35504#issuecomment-1877494327 Could you share the traceback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2024-01-04 Thread via GitHub
o-nikolas commented on PR #35504: URL: https://github.com/apache/airflow/pull/35504#issuecomment-1877475118 Unfortunately we're seeing periodic failures in our fargate system tests (see the original PR for more explanation [here](https://github.com/apache/airflow/pull/31622)) after this ret

Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2023-11-07 Thread via GitHub
dstandish merged PR #35504: URL: https://github.com/apache/airflow/pull/35504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo