dstandish commented on PR #34790:
URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751054119
> I'm fine with it but lets at least add entry about this in the change log
that explains this decision. Simply log it at the top of the provider change
log I will handle the style an
jedcunningham commented on PR #34790:
URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751050176
> well, if we're gonna do that, should we go all out and make it `_es_read`
/ `:meta private:`?
Works for me.
--
This is an automated message from the Apache Git Service.
eladkal commented on PR #34790:
URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751047992
> My take is it's internal to the ES log handler, shouldn't be a problem to
remove it.
I'm fine with it but lets at least add entry about this in the change log
that explains this de
dstandish commented on PR #34790:
URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751033093
> My take is it's internal to the ES log handler, shouldn't be a problem to
remove it.
well, if we're gonna do that, should we go all out and make it `_es_read` /
`:meta privat
dstandish commented on PR #34790:
URL: https://github.com/apache/airflow/pull/34790#issuecomment-1749747898
airflow should make things all private unless a `@public` decorator is
added default private everywhere
--
This is an automated message from the Apache Git Service.
To respond t
dstandish commented on PR #34790:
URL: https://github.com/apache/airflow/pull/34790#issuecomment-1749747488
> We should consider `es_read` as private, yeah?
Oh boy...
well... maybe technically we can't but 🤷
--
This is an automated message from the Apache Git Service.
To respond
jedcunningham commented on PR #34790:
URL: https://github.com/apache/airflow/pull/34790#issuecomment-1749738493
We should consider `es_read` as private, yeah?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
dstandish opened a new pull request, #34790:
URL: https://github.com/apache/airflow/pull/34790
Not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
