Re: [PR] Remove unused argument metadata from es_read and make clearly private [airflow]

2023-10-13 Thread via GitHub
eladkal merged PR #34790: URL: https://github.com/apache/airflow/pull/34790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Remove unused argument metadata from es_read and make clearly private [airflow]

2023-10-06 Thread via GitHub
eladkal commented on code in PR #34790: URL: https://github.com/apache/airflow/pull/34790#discussion_r1348968540 ## airflow/providers/elasticsearch/CHANGELOG.rst: ## @@ -27,6 +27,17 @@ Changelog - +5.1.0 +. + +Misc + Review Comment: please remove. we don'

Re: [PR] Remove unused argument metadata from es_read and make clearly private [airflow]

2023-10-06 Thread via GitHub
dstandish commented on PR #34790: URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751093699 ok @eladkal i added the docs note. i also renamed it `_es_read`. if you think the method rename goes too far LMK -- This is an automated message from the Apache Git Service. To re