Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]

2024-03-16 Thread via GitHub
eladkal merged PR #38051: URL: https://github.com/apache/airflow/pull/38051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]

2024-03-16 Thread via GitHub
eladkal commented on code in PR #38051: URL: https://github.com/apache/airflow/pull/38051#discussion_r1527143611 ## airflow/providers/apache/spark/operators/spark_jdbc.py: ## @@ -44,14 +44,6 @@ class SparkJDBCOperator(SparkSubmitOperator): :param spark_files: Additional fil

Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]

2024-03-16 Thread via GitHub
shahar1 commented on code in PR #38051: URL: https://github.com/apache/airflow/pull/38051#discussion_r1527140569 ## airflow/providers/apache/spark/operators/spark_jdbc.py: ## @@ -44,14 +44,6 @@ class SparkJDBCOperator(SparkSubmitOperator): :param spark_files: Additional fil

Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]

2024-03-16 Thread via GitHub
eladkal commented on code in PR #38051: URL: https://github.com/apache/airflow/pull/38051#discussion_r1527138900 ## airflow/providers/apache/spark/operators/spark_jdbc.py: ## @@ -44,14 +44,6 @@ class SparkJDBCOperator(SparkSubmitOperator): :param spark_files: Additional fil

Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]

2024-03-15 Thread via GitHub
shahar1 commented on PR #38051: URL: https://github.com/apache/airflow/pull/38051#issuecomment-134890 > There are conflicts :( Fixed; it's expected as we remove an entry in each PR from `.pre-commit-config.yaml`, and sometimes GIT can't resolve it :) -- This is an automated me

Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]

2024-03-15 Thread via GitHub
eladkal commented on PR #38051: URL: https://github.com/apache/airflow/pull/38051#issuecomment-122501 There are conflicts :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme