Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870576151 Aaaand surprise surprise ... Merging the revert fixed the problem ?!?! this is a very strange issue -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870549976 Merged. It failed 3 times in a row now -let's see if that one will fix main ... Would be super strange but with this kind of side effect, it could be something very, very unrelated --

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk merged PR #36453: URL: https://github.com/apache/airflow/pull/36453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870507227 Merged the https://github.com/apache/airflow/actions/runs/7340642180 to see the third failure. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870506063 Let's merge it to see if it helps. We had two subsequent main failures after merging PRs -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870459146 Let's see the next one https://github.com/apache/airflow/actions/runs/7340134340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870408717 Let's see https://github.com/apache/airflow/actions/runs/7339685558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870398887 > More interesting why this error appear again 🤔 Indeed .. that's very interesting. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
Taragolis commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870398065 Maybe we could return to previous solution, when we manually filtered log records by a logger name instead of provide it into the `caplog.at_level`. More interesting why this e

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870389831 > I think this all errors refers to the old issue with this test, previous attempt before we migrate everything to the pytest: 🤔 -- This is an automated message from the Apache

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870388599 Also reverting it and running few times `main` merge without seeing the error after seeing it in few other builds before merge, might give more clues. I plan to merge a few more PRs and

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
Taragolis commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870387449 I think this all errors refers to the old issue with this test, previous attempt before we migrate everything to the pytest: - https://github.com/apache/airflow/pull/27105 -- Thi

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870386686 So far It somehow looks liks this failure only happens in `main` (I have not seen it in any PR) - so maybe there is a difference that I will be able to track if I will get enough evidenc

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870385260 I know :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
hussein-awala commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870383689 There is nothing related to asyncio in this change 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk closed pull request #36453: Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… URL: https://github.com/apache/airflow/pull/36453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk commented on PR #36453: URL: https://github.com/apache/airflow/pull/36453#issuecomment-1870382663 Seems that after merging that limited PR - the error started to appear again. Let's see what happens in the PR. -- This is an automated message from the Apache Git Service. To respond

[PR] Revert "Remove remaining Airflow 2.5 backcompat code from GCS Task Ha… [airflow]

2023-12-27 Thread via GitHub
potiuk opened a new pull request, #36453: URL: https://github.com/apache/airflow/pull/36453 …ndler (#36443)" This reverts commit 75faf1115d990746784e25280c0b326b3b557b86. --- **^ Add meaningful description above** Read the **[Pull Request Guide