Re: [PR] Sanitize filenames in MySQLHook [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1875577456 Cool. Thanks for fixing it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2024-01-03 Thread via GitHub
potiuk merged PR #33328: URL: https://github.com/apache/airflow/pull/33328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2024-01-03 Thread via GitHub
PApostol commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1875561872 Hello, I have updated the PR, tests seem to pass now. Perhaps it can be reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2023-11-28 Thread via GitHub
potiuk commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1831042545 Yep. it looks like: > Perhaps this can be merged now? So ... no :) until it is fixed :) -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2023-11-28 Thread via GitHub
potiuk commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1831033558 There was an error that looked suspiciously related (MySQL test failed but also could be flake) I re-run it - if it happens again I think you will need to fix it @PApostol -- This is

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2023-11-26 Thread via GitHub
potiuk commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1827002456 Rebased it. Generatlly when we have old PRs that (for whatever reason) has not been built for some time, rebasing is firt thing to do. -- This is an automated message from the Apache G

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2023-11-26 Thread via GitHub
PApostol commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1826985831 Perhaps this can be merged now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1823681701 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2023-10-08 Thread via GitHub
potiuk commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1752130679 yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,