Re: [PR] Sqlalchemy dependency update [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-2094514322 Already fixed in https://github.com/apache/airflow/pull/38362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Sqlalchemy dependency update [airflow]

2024-05-04 Thread via GitHub
Taragolis closed pull request #38066: Sqlalchemy dependency update URL: https://github.com/apache/airflow/pull/38066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Sqlalchemy dependency update [airflow]

2024-05-04 Thread via GitHub
github-actions[bot] commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-2094510233 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-20 Thread via GitHub
potiuk commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1531807443 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": { -

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-20 Thread via GitHub
potiuk commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1531807443 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": { -

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-14 Thread via GitHub
amindadgar commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1525821374 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": {

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-14 Thread via GitHub
amindadgar commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-1999032280 > > @Taragolis Thanks for your checking. So I see two options > > > > 1. Wait for FAB library to update their dependency or > > 2. To contribute to their library > > >

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-13 Thread via GitHub
Taragolis commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1524026122 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": { -

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-13 Thread via GitHub
uranusjr commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1523751495 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": { -

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-13 Thread via GitHub
uranusjr commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1523751495 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": { -

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-13 Thread via GitHub
Taragolis commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1523709944 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": { -

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-12 Thread via GitHub
uranusjr commented on code in PR #38066: URL: https://github.com/apache/airflow/pull/38066#discussion_r1521933004 ## airflow/settings.py: ## @@ -273,7 +273,7 @@ def configure_orm(disable_connection_pool=False, pool_class=None): DEFAULT_ENGINE_ARGS = { "postgresql": { -

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-12 Thread via GitHub
Taragolis commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-1991328183 It might be good to change default value for execute many for PG, because seems like it didn't change for a long time, and it only valid in SA 1.3, SA 1.4 look like silently fallback

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-12 Thread via GitHub
potiuk commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-1991315807 > @Taragolis Thanks for your checking. So I see two options > > 1. Wait for FAB library to update their dependency or > 2. To contribute to their library > > Is there anot

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-12 Thread via GitHub
amindadgar commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-1991127737 @Taragolis Thanks for your checking. So I see two options 1. Wait for FAB library to update their dependency or 2. To contribute to their library Is there another easy way

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-12 Thread via GitHub
Taragolis commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-1991060437 https://github.com/apache/airflow/blob/7213fc5b7a5cb9b69fc9f42126f44d214a24b575/pyproject.toml#L136-L139 And we also have a FAB (Flask APP Builder) which also limited by `sqlacl

Re: [PR] Sqlalchemy dependency update [airflow]

2024-03-12 Thread via GitHub
boring-cyborg[bot] commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-1991047739 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Sqlalchemy dependency update [airflow]

2024-03-12 Thread via GitHub
amindadgar opened a new pull request, #38066: URL: https://github.com/apache/airflow/pull/38066 Updating executemany_mode for supporting sqlalchemy>=2.0.0 Trying to resolve the issue https://github.com/apache/airflow/issues/38064 --- **^ Add meaningful descrip