github-actions[bot] closed pull request #35564: Stop logo clashing when
pinwheel animates
URL: https://github.com/apache/airflow/pull/35564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1891124320
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for
bbovenzi commented on code in PR #35564:
URL: https://github.com/apache/airflow/pull/35564#discussion_r1408504490
##
airflow/www/static/css/main.css:
##
@@ -105,7 +119,17 @@ div.container {
@media (prefers-reduced-motion: no-preference) {
.navbar-brand:hover
eladkal commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1826372173
> Besides lagging the "Easter Egg" history I very much like the animation
and would prefer to keep it. I am not a 100% designed but I treated the text
shift as rather "cool" :-D But
jscheffl commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1819692172
> > > > I agree with Ryan, this was mainly an Easter Egg. I don't know if we
want to mess with the logo too much. Can we double check everywhere else we use
the Airflow SVG?
> > >
caitpj commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1813250972
How does something like this look? The downside to this option is it doesn't
give as tight a connection between the logo pinwheel and the logo text, saying
that, it doesn't disconnect
potiuk commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1812886658
> > > I agree with Ryan, this was mainly an Easter Egg. I don't know if we
want to mess with the logo too much. Can we double check everywhere else we use
the Airflow SVG?
> >
>
bbovenzi commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1812821523
> > I agree with Ryan, this was mainly an Easter Egg. I don't know if we
want to mess with the logo too much. Can we double check everywhere else we use
the Airflow SVG?
>
>
caitpj commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1811089392
> I agree with Ryan, this was mainly an Easter Egg. I don't know if we want
to mess with the logo too much. Can we double check everywhere else we use the
Airflow SVG?
@bbovenzi
bbovenzi commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1810781908
I agree with Ryan, this was mainly an Easter Egg. I don't know if we want to
mess with the logo too much. Can we double check everywhere else we use the
Airflow SVG?
--
This is an
ryanahamilton commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1810310111
Figured I'd weigh in since I was the one who originally added this
animation… The overlap was certainly something I noticed when implementing. I
didn't increase the spacing
potiuk commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1809243996
(and agree - when you move out the mouse, this is really disturbing when it
suddenly goes back to start)
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1809242943
> Maybe just move "Airflow" over a bit so that doesn't need to start moving
too? In the "after" video it feels a bit jarring imo.
Now we are talking design :D
--
This is an
jedcunningham commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1809224469
Maybe just move "Airflow" over a bit so that doesn't need to start moving
too? In the "after" video it feels a bit jarring imo.
--
This is an automated message from the Apache
pankajkoti commented on code in PR #35564:
URL: https://github.com/apache/airflow/pull/35564#discussion_r1391097024
##
airflow/www/static/css/main.css:
##
@@ -105,7 +119,17 @@ div.container {
@media (prefers-reduced-motion: no-preference) {
.navbar-brand:hover
caitpj commented on code in PR #35564:
URL: https://github.com/apache/airflow/pull/35564#discussion_r1391058081
##
airflow/www/static/css/main.css:
##
@@ -105,7 +119,17 @@ div.container {
@media (prefers-reduced-motion: no-preference) {
.navbar-brand:hover
pankajkoti commented on code in PR #35564:
URL: https://github.com/apache/airflow/pull/35564#discussion_r1390993607
##
airflow/www/static/css/main.css:
##
@@ -105,7 +119,17 @@ div.container {
@media (prefers-reduced-motion: no-preference) {
.navbar-brand:hover
potiuk commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1806736878
> > I think what would help to evaluate this change (not by me - I am pretty
far from UI) is if you add some recorded videos before and after. It might be
that what you see is somewhat
caitpj commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1806507429
> I think what would help to evaluate this change (not by me - I am pretty
far from UI) is if you add some recorded videos before and after. It might be
that what you see is somewhat
potiuk commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1806046319
I think what would help to evaluate this change (not by me - I am pretty far
from UI) is if you add some recorded videos before and after. It might be that
what you see is somewhat
caitpj opened a new pull request, #35564:
URL: https://github.com/apache/airflow/pull/35564
When hovering over the Airflow logo in the top left, the pinwheel part of
the logo cuts across the text part of the logo. This is (subjectively) poor
design. In order to stop this from happening,
boring-cyborg[bot] commented on PR #35564:
URL: https://github.com/apache/airflow/pull/35564#issuecomment-1804869053
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
22 matches
Mail list logo
