Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] closed pull request #34927: Support Personal access token method for Tableau Connection URL: https://github.com/apache/airflow/pull/34927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2024-01-09 Thread via GitHub
github-actions[bot] commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1883991199 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-11-25 Thread via GitHub
eladkal commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1826250373 > @Michae94 Is the concurrency problem what you meant before in Kubernetes? Do you have any recommendation for me on how to improve the process? Can I configure somewhere in the Airflow

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-11-24 Thread via GitHub
baruch-shteken commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1825922057 I tested my changes locally (I didn't manage to pull my changes from GitHub. However, we use an Airflow docker so I changed the file `airflow/providers/tableau/hooks/tableau.py`

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-11-06 Thread via GitHub
eladkal commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1797874755 > Example of the problem: Let's take an example of a DAG that has 2 parallel tasks that refresh 2 Tableau data sources. One of these tasks will generate and use a session_token to re

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-10-31 Thread via GitHub
baruch-shteken commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1787580578 I don't know how Airflow kubernetes workers work but if they all use the code I propose here and even with the same PAT, it should still be ok. Because each task will authenticat

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-10-31 Thread via GitHub
Michae94 commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1787575760 Ok now I understand better your proposition. Potentially, it means that this improvement will not be usable for Airflow kubernetes workers, as each task is performed on a different

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-10-31 Thread via GitHub
baruch-shteken commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1787565032 @Michae94 If the two jobs run in a different machine then I think they should use a different PAT. I would say that for each app, there should be a dedicated PAT. So Airflow

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-10-31 Thread via GitHub
Michae94 commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1787522055 Hey @baruch-shteken , thanks for the answer. I agree with everything you mentioned above, except the conclusion. Let's say we have 2 concurrent tasks, completely isolated (not

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-10-31 Thread via GitHub
baruch-shteken commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1787385444 Thanks @Michae94 for your question. **This is my understanding of how PATs work**: When a PAT is used for an authentication, it creates a new `session_token` which is then u

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-10-24 Thread via GitHub
Michae94 commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1777141990 Hey @baruch-shteken , thanks for posting a PR for this issue. I was wondering how this new setup will work with multiple concurrent tasks using the same PAT. From m