Re: [PR] Support checking for db path absoluteness on Windows [airflow]

2024-06-12 Thread via GitHub
potiuk merged PR #40069: URL: https://github.com/apache/airflow/pull/40069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support checking for db path absoluteness on Windows [airflow]

2024-06-07 Thread via GitHub
Dev-iL commented on code in PR #40069: URL: https://github.com/apache/airflow/pull/40069#discussion_r1630941654 ## airflow/settings.py: ## @@ -278,17 +278,24 @@ def remove(*args, **kwargs): pass +def _is_sqlite_db_path_relative(sqla_conn_str: str) -> bool: +

Re: [PR] Support checking for db path absoluteness on Windows [airflow]

2024-06-07 Thread via GitHub
uranusjr commented on code in PR #40069: URL: https://github.com/apache/airflow/pull/40069#discussion_r1630854677 ## tests/core/test_settings.py: ## @@ -230,12 +230,22 @@ def test_uses_updated_session_timeout_config_by_default(self): assert session_lifetime_config ==

Re: [PR] Support checking for db path absoluteness on Windows [airflow]

2024-06-07 Thread via GitHub
uranusjr commented on code in PR #40069: URL: https://github.com/apache/airflow/pull/40069#discussion_r1630851968 ## airflow/settings.py: ## @@ -278,17 +278,24 @@ def remove(*args, **kwargs): pass +def _is_sqlite_db_path_relative(sqla_conn_str: str) -> bool: +

Re: [PR] Support checking for db path absoluteness on Windows [airflow]

2024-06-06 Thread via GitHub
Dev-iL commented on code in PR #40069: URL: https://github.com/apache/airflow/pull/40069#discussion_r1628924640 ## airflow/settings.py: ## @@ -278,17 +280,29 @@ def remove(*args, **kwargs): pass +def _is_sqlite_db_path_relative(sqla_conn_str: str) -> bool: +

Re: [PR] Support checking for db path absoluteness on Windows [airflow]

2024-06-05 Thread via GitHub
uranusjr commented on code in PR #40069: URL: https://github.com/apache/airflow/pull/40069#discussion_r1628585916 ## airflow/settings.py: ## @@ -278,17 +280,29 @@ def remove(*args, **kwargs): pass +def _is_sqlite_db_path_relative(sqla_conn_str: str) -> bool: +

[PR] Support checking for db path absoluteness on Windows [airflow]

2024-06-05 Thread via GitHub
Dev-iL opened a new pull request, #40069: URL: https://github.com/apache/airflow/pull/40069 --- Airflow isn't supported on Windows at the moment. However, various components of Airflow work perfectly fine when given the chance. I have a use case where I'm