hussein-awala commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872652191
> > Ok. As @hussein-awala said, it's worth trying accessing DB using async.
This is a healthy discussion. Thank you @potiuk.
>
> Yep. I am waiting to see it 👀 Therea are two
potiuk commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872549992
> Ok. As @hussein-awala said, it's worth trying accessing DB using async.
This is a healthy discussion. Thank you @potiuk.
Yep. I am waiting to see it :eyes: Therea are two proble
dirrao commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872547808
> > Yes. You are right. It makes even more sense in the case of
request/response APIs. However, in airflow, the trigger might run for
seconds/minutes/hours (ex: S3KeyTrigger, KubernetesP
potiuk commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872543877
> Yes. You are right. It makes even more sense in the case of
request/response APIs. However, in airflow, the trigger might run for
seconds/minutes/hours (ex: S3KeyTrigger, KubernetesPod
dirrao commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872537980
> > I have tried accessing the variables from the trigger run function
multiple times after multiple context switches in event loop. I can access the
variable values without any issues
potiuk commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872534863
> I'm running a POC to make this easily possible without blocking the event
loop and will create a new AIP soon 🤞
:eyes:
--
This is an automated message from the Apache Git Ser
hussein-awala commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872534368
> The problem is that if you do it during the event loop, the access (if not
using async/await) will block - in I/O or networking and when it is blocked, no
other triggers are run
potiuk commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872533458
> I have tried accessing the variables from the trigger run function
multiple times after multiple context switches in event loop. I can access the
variable values without any issues
dirrao commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872529072
> > > We usually access secrets from either disk or connections or encrypted
variables in airflow
> >
> >
> > Correct. This is possible, no doubt about it.
> > But it might
potiuk commented on code in PR #36492:
URL: https://github.com/apache/airflow/pull/36492#discussion_r1438593904
##
airflow/models/trigger.py:
##
@@ -90,8 +90,17 @@ def __init__(
@internal_api_call
def from_object(cls, trigger: BaseTrigger) -> Trigger:
"""Alter
potiuk commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872524904
And resolving the conversation enables merging. All cool :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
hussein-awala commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872524654
```
Merging is blocked
The base branch requires all conversations on code to be resolved.
```
🎉
--
This is an automated message from the Apache Git Service.
To respo
hussein-awala commented on code in PR #36492:
URL: https://github.com/apache/airflow/pull/36492#discussion_r1438591710
##
airflow/models/trigger.py:
##
@@ -90,8 +90,17 @@ def __init__(
@internal_api_call
def from_object(cls, trigger: BaseTrigger) -> Trigger:
"
hussein-awala commented on code in PR #36492:
URL: https://github.com/apache/airflow/pull/36492#discussion_r1438590907
##
airflow/models/trigger.py:
##
@@ -90,8 +90,17 @@ def __init__(
@internal_api_call
def from_object(cls, trigger: BaseTrigger) -> Trigger:
"
potiuk commented on code in PR #36492:
URL: https://github.com/apache/airflow/pull/36492#discussion_r1438589955
##
airflow/models/trigger.py:
##
@@ -90,8 +90,17 @@ def __init__(
@internal_api_call
def from_object(cls, trigger: BaseTrigger) -> Trigger:
"""Alter
dirrao commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872477618
> > We usually access secrets from either disk or connections or encrypted
variables in airflow
>
> Correct. This is possible, no doubt about it.
>
> But it might quite a bi
potiuk commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872474138
> We usually access secrets from either disk or connections or encrypted
variables in airflow
Correct. This is possible, no doubt about it.
But it might quite a bit comple
dirrao commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872469573
> > Nice work. Can't we access the variables and connections from the
trigger run? What is the recommended pattern for accessing the sensitive
information from the trigger run?
>
potiuk commented on PR #36492:
URL: https://github.com/apache/airflow/pull/36492#issuecomment-1872463217
> Nice work. Can't we access the variables and connections from the trigger
run? What is the recommended pattern for accessing the sensitive information
from the trigger run?
We c
hussein-awala opened a new pull request, #36492:
URL: https://github.com/apache/airflow/pull/36492
This PR implements a way to encrypt some of the trigger parameters using
fernet before storing them in the database.
--
This is an automated message from the Apache Git Service.
To respond t
20 matches
Mail list logo
