Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-09-10 Thread via GitHub
boring-cyborg[bot] commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2341542029 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-09-09 Thread via GitHub
sc-anssi commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2337585317 > @sc-anssi So then I would say... if you fix the static checks then we could merge it and back-port to a 2.10.2 release... Spelling is fixed, please let me know if anything else

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-09-04 Thread via GitHub
jscheffl commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2329570708 > > Some static checks fail. Though I like the implementation a lot more than before... actually as project team we have decided (1) that Airflow 2.10 will only get new features in exc

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2329358130 > Some static checks fail. Though I like the implementation a lot more than before... actually as project team we have decided (1) that Airflow 2.10 will only get new features in excep

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-08-31 Thread via GitHub
jscheffl commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2323044478 Some static checks fail. Though I like the implementation a lot more than before... actually as project team we have decided (1) that Airflow 2.10 will only get new features in excepti

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-08-25 Thread via GitHub
github-actions[bot] commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2309064126 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-07-11 Thread via GitHub
sc-anssi commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-928469 Thanks for the feedback ! I'll try to check whether the `format` attribute of the JSON schema for `string` type can be used in this case. -- This is an automated message from the Apa