Taragolis merged PR #38466:
URL: https://github.com/apache/airflow/pull/38466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
oboki commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1544832963
##
airflow/providers/docker/hooks/docker.py:
##
@@ -146,15 +151,23 @@ def construct_tls_config(
@cached_property
def api_client(self) -> APIClient:
"
Taragolis commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1543759158
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,20 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
Taragolis commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1543749181
##
airflow/providers/docker/operators/docker.py:
##
@@ -283,6 +283,8 @@ def __init__(
self.dns = dns
self.dns_search = dns_search
self.do
oboki commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1539552742
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,20 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
ssl
oboki commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1539548331
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,21 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
ssl
oboki commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1539536475
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,21 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
ssl
Taragolis commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1538673076
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,20 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
Taragolis commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1538671107
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,21 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
oboki commented on PR #38466:
URL: https://github.com/apache/airflow/pull/38466#issuecomment-2019021779
@Taragolis Thank you for the detailed review. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
oboki commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1538300908
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,21 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
ssl
oboki commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1538292974
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,21 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
ssl
Taragolis commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1537947062
##
airflow/providers/docker/operators/docker.py:
##
@@ -343,13 +345,21 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
oboki opened a new pull request, #38466:
URL: https://github.com/apache/airflow/pull/38466
This PR improves `DockerOperator` to support multiple Docker hosts, enabling
high availability.
Changes include:
- Allowing the `docker_url` parameter to accept a list of str.
- Iterating
14 matches
Mail list logo
