dhruvmanila commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1378344674
##
airflow/api/common/delete_dag.py:
##
@@ -72,7 +72,7 @@ def delete_dag(dag_id: str, keep_records_in_log: bool = True,
session: Session =
)
)
-
kaxil merged PR #35287:
URL: https://github.com/apache/airflow/pull/35287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.ap
kaxil commented on PR #35287:
URL: https://github.com/apache/airflow/pull/35287#issuecomment-1788142100
The current constraints failure is unrelated and affects other PRs too,
example https://github.com/apache/airflow/pull/35312 , merging this PR
--
This is an automated message from the A
jedcunningham commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377925565
##
airflow/api/common/delete_dag.py:
##
@@ -72,7 +72,7 @@ def delete_dag(dag_id: str, keep_records_in_log: bool = True,
session: Session =
)
)
jedcunningham commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377918877
##
airflow/models/dag.py:
##
@@ -3618,7 +3618,7 @@ def get_paused_dag_ids(dag_ids: list[str], session:
Session = NEW_SESSION) -> se
.where(DagMode
jlaneve commented on PR #35287:
URL: https://github.com/apache/airflow/pull/35287#issuecomment-1787633576
note that I added back inline tuples - turns out they were actually correct.
see https://github.com/apache/airflow/actions/runs/6708119087/job/18230292697
--
This is an automated mess
jlaneve commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377712293
##
airflow/api/common/delete_dag.py:
##
@@ -72,7 +72,7 @@ def delete_dag(dag_id: str, keep_records_in_log: bool = True,
session: Session =
)
)
-d
jlaneve commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377711652
##
airflow/providers/google/cloud/transfers/bigquery_to_mssql.py:
##
@@ -63,8 +63,7 @@ def __init__(
if mssql_table is not None:
warnings.warn(
jlaneve commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377709828
##
tests/providers/common/sql/operators/test_sql.py:
##
@@ -131,15 +131,15 @@ class TestColumnCheckOperator:
UNION ALL
SELECT 'X' AS col_name, 'distinct
jlaneve commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377708296
##
tests/system/providers/docker/example_docker.py:
##
@@ -54,9 +54,7 @@
(
# TEST BODY
-t1
->> [t2, t3]
->> t4
+t1 >>
Taragolis commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377671630
##
airflow/api/common/delete_dag.py:
##
@@ -72,7 +72,7 @@ def delete_dag(dag_id: str, keep_records_in_log: bool = True,
session: Session =
)
)
-
kaxil commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377553765
##
tests/providers/common/sql/operators/test_sql.py:
##
@@ -131,15 +131,15 @@ class TestColumnCheckOperator:
UNION ALL
SELECT 'X' AS col_name, 'distinct_c
kaxil commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377552986
##
airflow/api/common/delete_dag.py:
##
@@ -72,7 +72,7 @@ def delete_dag(dag_id: str, keep_records_in_log: bool = True,
session: Session =
)
)
-dag
Taragolis commented on code in PR #35287:
URL: https://github.com/apache/airflow/pull/35287#discussion_r1377461406
##
.pre-commit-config.yaml:
##
@@ -181,13 +174,16 @@ repos:
pass_filenames: false
require_serial: true
- repo: https://github.com/astral-sh/ruf
potiuk commented on PR #35287:
URL: https://github.com/apache/airflow/pull/35287#issuecomment-1786890962
Looks like it works. Care to undraft it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
15 matches
Mail list logo
