Re: [PR] Template field support for configmaps in the KubernetesPodOperator [airflow]

2024-01-19 Thread via GitHub
eladkal commented on code in PR #36922: URL: https://github.com/apache/airflow/pull/36922#discussion_r1460281199 ## newsfragments/36922.feature.rst: ## @@ -0,0 +1 @@ +Support for configmaps in the template fields in the KubernetesPodOperator Review Comment: Please remove thi

Re: [PR] Template field support for configmaps in the KubernetesPodOperator [airflow]

2024-01-20 Thread via GitHub
eladkal commented on PR #36922: URL: https://github.com/apache/airflow/pull/36922#issuecomment-1902067591 We need to make sure this PR doesn't add extra work for https://github.com/apache/airflow/issues/36484 cc @romsharon98 -- This is an automated message from the Apache Git Service.

Re: [PR] Template field support for configmaps in the KubernetesPodOperator [airflow]

2024-01-20 Thread via GitHub
romsharon98 commented on PR #36922: URL: https://github.com/apache/airflow/pull/36922#issuecomment-1902087188 > We need to make sure this PR doesn't add extra work for #36484 cc @romsharon98 Checked it, looks good. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Template field support for configmaps in the KubernetesPodOperator [airflow]

2024-01-20 Thread via GitHub
hussein-awala merged PR #36922: URL: https://github.com/apache/airflow/pull/36922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Template field support for configmaps in the KubernetesPodOperator [airflow]

2024-01-20 Thread via GitHub
boring-cyborg[bot] commented on PR #36922: URL: https://github.com/apache/airflow/pull/36922#issuecomment-1902185023 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.