Re: [PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-11-04 Thread via GitHub
pierrejeambrun closed pull request #99: The sanitize_for_serialization(cls, obj) function outputs an incorret time format URL: https://github.com/apache/airflow-client-python/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-11-04 Thread via GitHub
pierrejeambrun commented on PR #99: URL: https://github.com/apache/airflow-client-python/pull/99#issuecomment-1793522046 Cf https://github.com/apache/airflow-client-python/issues/98#issuecomment-1793521855 comments, closing, feel free to re-open if needed. (The API requires a TZ awa

Re: [PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-10-26 Thread via GitHub
junqilv commented on PR #99: URL: https://github.com/apache/airflow-client-python/pull/99#issuecomment-1780957830 My test steps are as follows: First, when I tried to pass data in datetime format to logical_date, I found that the http request returned showed that the format of logical_da

Re: [PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-10-26 Thread via GitHub
junqilv commented on PR #99: URL: https://github.com/apache/airflow-client-python/pull/99#issuecomment-1780921520 > Hello, > > Can you try with a timezone aware datetime in the client? (For instance datetime.utcnow()) Thank for your attention to this pull request. This has noth

Re: [PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-10-26 Thread via GitHub
pierrejeambrun commented on PR #99: URL: https://github.com/apache/airflow-client-python/pull/99#issuecomment-1780534125 Hello, Can you try with a timezone aware datetime in the client? (For instance datetime.utcnow()) -- This is an automated message from the Apache Git Servic

Re: [PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-10-25 Thread via GitHub
junqilv commented on PR #99: URL: https://github.com/apache/airflow-client-python/pull/99#issuecomment-1780268698 > Could you please explain (in commit message ideally as well) what was the problem it solves ? I don't see why it was wrong b) it would require to have test added. When

Re: [PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-10-25 Thread via GitHub
potiuk commented on PR #99: URL: https://github.com/apache/airflow-client-python/pull/99#issuecomment-1779932375 Could you please explain (in commit message ideally as well) what was the problem it solves ? I don't see why it was wrong b) it would require to have test added. -- This i

[PR] The sanitize_for_serialization(cls, obj) function outputs an incorret time format [airflow-client-python]

2023-10-25 Thread via GitHub
junqilv opened a new pull request, #99: URL: https://github.com/apache/airflow-client-python/pull/99 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc