[PR] Trino: support config timezone [airflow]

2023-10-24 Thread via GitHub
duyet opened a new pull request, #35147: URL: https://github.com/apache/airflow/pull/35147 Support config trino timezone by providing it in connection extra field ```json { "timezone": "Asia/Ho_Chi_Minh" } ``` https://github.com/trinodb/trino-python-client?

Re: [PR] Trino: support config timezone [airflow]

2023-12-01 Thread via GitHub
eladkal commented on PR #35147: URL: https://github.com/apache/airflow/pull/35147#issuecomment-1836498344 Closed in favor of https://github.com/apache/airflow/pull/35963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Trino: support config timezone [airflow]

2023-12-01 Thread via GitHub
eladkal closed pull request #35147: Trino: support config timezone URL: https://github.com/apache/airflow/pull/35147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Trino: support config timezone [airflow]

2023-10-24 Thread via GitHub
Taragolis commented on code in PR #35147: URL: https://github.com/apache/airflow/pull/35147#discussion_r1369762719 ## airflow/providers/trino/hooks/trino.py: ## @@ -145,6 +145,7 @@ def get_conn(self) -> Connection: verify=_boolify(extra.get("verify", True)),

Re: [PR] Trino: support config timezone [airflow]

2023-10-24 Thread via GitHub
Taragolis commented on PR #35147: URL: https://github.com/apache/airflow/pull/35147#issuecomment-1776917304 And also tests should be adopted to the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Trino: support config timezone [airflow]

2023-11-01 Thread via GitHub
eladkal commented on PR #35147: URL: https://github.com/apache/airflow/pull/35147#issuecomment-1790043336 @duyet can you please add a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th