utkarsharma2 opened a new pull request, #39636:
URL: https://github.com/apache/airflow/pull/39636
This PR introduces the UI changes required to consume the DAG Reparsing API.
## Home page
![Screenshot 2024-05-15 at 4 59 07
PM](https://github.com/apache/airflow/assets/13021213/0bc1f15b-
utkarsharma2 commented on code in PR #39636:
URL: https://github.com/apache/airflow/pull/39636#discussion_r1601463232
##
airflow/www/static/js/main.js:
##
@@ -287,3 +287,18 @@ $(document).ready(() => {
// Global Tooltip selector
$(".js-tooltip").tooltip();
});
+
+$(".repa
utkarsharma2 commented on code in PR #39636:
URL: https://github.com/apache/airflow/pull/39636#discussion_r1602730532
##
airflow/www/static/js/main.js:
##
@@ -287,3 +287,18 @@ $(document).ready(() => {
// Global Tooltip selector
$(".js-tooltip").tooltip();
});
+
+$(".repa
bbovenzi commented on code in PR #39636:
URL: https://github.com/apache/airflow/pull/39636#discussion_r1603746731
##
airflow/www/static/js/main.js:
##
@@ -287,3 +287,18 @@ $(document).ready(() => {
// Global Tooltip selector
$(".js-tooltip").tooltip();
});
+
+$(".reparse_
bbovenzi commented on code in PR #39636:
URL: https://github.com/apache/airflow/pull/39636#discussion_r1603747223
##
airflow/www/templates/airflow/dags.html:
##
@@ -398,6 +398,10 @@ {{ page_title }}
class="btn btn-sm btn-default btn-icon-only{{ ' disabled'
utkarsharma2 commented on code in PR #39636:
URL: https://github.com/apache/airflow/pull/39636#discussion_r1604941192
##
airflow/www/templates/airflow/dags.html:
##
@@ -398,6 +398,10 @@ {{ page_title }}
class="btn btn-sm btn-default btn-icon-only{{ ' disable
utkarsharma2 commented on code in PR #39636:
URL: https://github.com/apache/airflow/pull/39636#discussion_r1604943555
##
airflow/www/static/js/main.js:
##
@@ -287,3 +287,18 @@ $(document).ready(() => {
// Global Tooltip selector
$(".js-tooltip").tooltip();
});
+
+$(".repa
eladkal commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2119166649
The icon might be misleading. It may be confused with refresh page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
raphaelauv commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2119181584
maybe something like
![re_parse](https://icons.veryicon.com/png/o/education-technology/online-school-applet/view-parsing.png)
--
This is an automated message from the Apach
utkarsharma2 commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2120227411
> maybe something like
>
>
![re_parse](https://camo.githubusercontent.com/3d12565c307f6722efb5edff2ac13ab4da2afa002dce93810eaff6b60a476636/68747470733a2f2f69636f6e732e7665727
raphaelauv commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2120304664
@utkarsharma2 yes you are right
then this ?
![image](https://github.com/apache/airflow/assets/10202690/01c64c56-3ec4-4760-9819-67ba6fe97c8f)
--
This is an automa
bbovenzi commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2120729661
> @utkarsharma2 yes you are right
>
> then this ?
>
>
![image](https://private-user-images.githubusercontent.com/10202690/332055966-01c64c56-3ec4-4760-9819-67ba6fe97c8f.pn
utkarsharma2 commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2122728401
> @utkarsharma2 yes you are right
>
> then this ?
>
>
![image](https://private-user-images.githubusercontent.com/10202690/332055966-01c64c56-3ec4-4760-9819-67ba6fe97c8
bbovenzi commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2123191828
Looks great to me!
Do the Dags list and dag details pages refresh once the DAG is reparsed?
--
This is an automated message from the Apache Git Service.
To respond to the messa
utkarsharma2 commented on PR #39636:
URL: https://github.com/apache/airflow/pull/39636#issuecomment-2123359434
> Do the Dags list and dag details pages refresh once the DAG is reparsed?
Yes, the redirect URL part handles it, right now.
--
This is an automated message from the Apache
utkarsharma2 merged PR #39636:
URL: https://github.com/apache/airflow/pull/39636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@air
16 matches
Mail list logo