[PR] Unify how docker commands get executed in Breeze [airflow]

2023-12-08 Thread via GitHub
potiuk opened a new pull request, #36131: URL: https://github.com/apache/airflow/pull/36131 So far we executed commands in CI image in breeze in two ways: * entering the shell (which runs docker-compose under the hood) * running `docker run` with the CI image This requires ra

Re: [PR] Unify how docker commands get executed in Breeze [airflow]

2023-12-09 Thread via GitHub
potiuk commented on code in PR #36131: URL: https://github.com/apache/airflow/pull/36131#discussion_r1421389322 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -170,60 +161,6 @@ class VersionedFile(NamedTuple): comparable_version: Version

Re: [PR] Unify how docker commands get executed in Breeze [airflow]

2023-12-09 Thread via GitHub
potiuk commented on code in PR #36131: URL: https://github.com/apache/airflow/pull/36131#discussion_r1421389322 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -170,60 +161,6 @@ class VersionedFile(NamedTuple): comparable_version: Version

Re: [PR] Unify how docker commands get executed in Breeze [airflow]

2023-12-10 Thread via GitHub
potiuk commented on PR #36131: URL: https://github.com/apache/airflow/pull/36131#issuecomment-1848950065 Right. Solved all the problems - should be ready to review now :). This is one more cleanup (including removal of +200 lines of redundant codee) where we have an easier way to unde

Re: [PR] Unify how docker commands get executed in Breeze [airflow]

2023-12-10 Thread via GitHub
potiuk merged PR #36131: URL: https://github.com/apache/airflow/pull/36131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a