eladkal merged PR #38191:
URL: https://github.com/apache/airflow/pull/38191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
shahar1 opened a new pull request, #38191:
URL: https://github.com/apache/airflow/pull/38191
related: #34982
closes: #34980
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/
github-actions[bot] closed pull request #34982: Update GCS hook to get crc32c
hash for CMEK-protected objects
URL: https://github.com/apache/airflow/pull/34982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1967947102
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
eladkal commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1890686018
@dmedora can you please fix the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
eladkal commented on code in PR #34982:
URL: https://github.com/apache/airflow/pull/34982#discussion_r1430574117
##
tests/providers/google/cloud/hooks/test_gcs.py:
##
@@ -1285,6 +1285,44 @@ def test_should_overwrite_files(self, mock_get_conn,
mock_delete, mock_rewrite,
eladkal commented on code in PR #34982:
URL: https://github.com/apache/airflow/pull/34982#discussion_r1430556197
##
tests/providers/google/cloud/hooks/test_gcs.py:
##
@@ -1253,6 +1253,45 @@ def test_should_overwrite_files(self, mock_get_conn,
mock_delete, mock_rewrite,
Taragolis commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1778304223
Are you worry about that you can't test internal static method
`_prepare_sync_plan`?
I don't see any problem here because it is internal part of Google Provider
so you could also t
dmedora commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1778213394
Thanks, still figuring out how to write the test correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Taragolis commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1778200695
Need to fix [static
checks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id5)
and failed test
--
This is an automated message from the Apache Git Service.
To
dmedora commented on code in PR #34982:
URL: https://github.com/apache/airflow/pull/34982#discussion_r1362613278
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1326,6 +1326,11 @@ def _prepare_sync_plan(
for current_name in names_to_check:
source_blo
Taragolis commented on code in PR #34982:
URL: https://github.com/apache/airflow/pull/34982#discussion_r1362568877
##
airflow/providers/google/cloud/hooks/gcs.py:
##
@@ -1326,6 +1326,11 @@ def _prepare_sync_plan(
for current_name in names_to_check:
source_b
heaven00 commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1765512475
sure,
so the function that has been changed is here is a private function, so we
can't test the logic that has been added but from what I can understand there
should be some be
dmedora commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1765496038
> Shouldn't this need a test against whatever that blob should be?
Not sure I understand, could you please explain further or with an example?
Thanks.
--
This is an automated m
heaven00 commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1765470742
Shouldn't this need a test against whatever that blob should be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
boring-cyborg[bot] commented on PR #34982:
URL: https://github.com/apache/airflow/pull/34982#issuecomment-1765202922
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
dmedora opened a new pull request, #34982:
URL: https://github.com/apache/airflow/pull/34982
Closes: #34980
Updated _prepare_sync_plan function to get blobs using the Objects Get API
(.get_blob(..)) so that their crc32c value is included in the returned Blob
object. As discussed in
17 matches
Mail list logo
